starknet_api: add and use StateRoots::EMPTY#13980
Conversation
PR SummaryMedium Risk Overview Updates committer tests, snap-sync CLI/tests, and the central systest blob regression helper to use Reviewed by Cursor Bugbot for commit fa76e6e. Bugbot is set up for automated code reviews on this repo. Configure here. |
85cd564 to
8bde747
Compare
bce4e03 to
860e7b2
Compare
8bde747 to
c9a7ca9
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware made 1 comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on nimrod-starkware and yoavGrs).
crates/starknet_api/src/hash.rs line 104 at r2 (raw file):
Previously, nimrod-starkware wrote…
I'm not sure it makes sense to have a default value for this...
I guess there are few places where StateRoots::default() was used to indicate an empty state, IMO it's better to be explicit there and change it to StateRoots::EMPTY
I agree, removed the impl
nimrod-starkware
left a comment
There was a problem hiding this comment.
@nimrod-starkware reviewed 5 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on yoavGrs).
88fb387 to
c504940
Compare
3700e92 to
fd1c2e9
Compare
c504940 to
10605ac
Compare
fd1c2e9 to
9f74247
Compare
20be49d to
80f2783
Compare
9f74247 to
6e16f47
Compare
6e16f47 to
1aa8f60
Compare
7741718 to
884af7d
Compare
1aa8f60 to
80bb904
Compare
884af7d to
3b9a787
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware reviewed 2 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on yoavGrs).
3b9a787 to
3d97fd4
Compare
3d97fd4 to
fa76e6e
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on yoavGrs).

No description provided.