Skip to content

central_systest_blobs: sort state diff in preconfirmed block#13971

Merged
dorimedini-starkware merged 1 commit into
mainfrom
04-30-central_systest_blobs_sort_state_diff_in_preconfirmed_block
May 9, 2026
Merged

central_systest_blobs: sort state diff in preconfirmed block#13971
dorimedini-starkware merged 1 commit into
mainfrom
04-30-central_systest_blobs_sort_state_diff_in_preconfirmed_block

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 5, 2026

@cursor
Copy link
Copy Markdown

cursor Bot commented May 5, 2026

PR Summary

Low Risk
Low risk: changes are test-only/testing-gated and primarily affect JSON determinism for regression blobs without altering production behavior.

Overview
Makes preconfirmed block regression output deterministic by sorting transaction state diffs before serializing them in central_systest_blobs.

Adds a StarknetClientStateDiff::sort() helper (gated behind test/testing) and enables the apollo_batcher testing feature in dev-dependencies so the regression test can call it.

Reviewed by Cursor Bugbot for commit 3960c26. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware self-assigned this May 5, 2026
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_deploy_operator_account branch from 135396f to aa45046 Compare May 5, 2026 11:18
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_sort_state_diff_in_preconfirmed_block branch from 694fc71 to 9672f60 Compare May 5, 2026 11:18
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_deploy_operator_account branch from aa45046 to 34b1097 Compare May 5, 2026 11:56
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_sort_state_diff_in_preconfirmed_block branch from 9672f60 to b04d116 Compare May 5, 2026 11:56
Copy link
Copy Markdown
Contributor

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@nimrod-starkware reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).

@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_deploy_operator_account branch from 34b1097 to 19531c8 Compare May 5, 2026 12:31
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_sort_state_diff_in_preconfirmed_block branch from b04d116 to 12e4044 Compare May 5, 2026 12:31
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_deploy_operator_account branch from 19531c8 to aa0ee34 Compare May 5, 2026 14:17
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_sort_state_diff_in_preconfirmed_block branch from 12e4044 to 0e28d9e Compare May 5, 2026 14:17
Copy link
Copy Markdown
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).

@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_deploy_operator_account branch from aa0ee34 to d469606 Compare May 8, 2026 13:49
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_sort_state_diff_in_preconfirmed_block branch from 0e28d9e to 05bf1a3 Compare May 8, 2026 13:49
Copy link
Copy Markdown
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).

@graphite-app graphite-app Bot changed the base branch from 04-30-central_systest_blobs_deploy_operator_account to graphite-base/13971 May 9, 2026 12:45
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_sort_state_diff_in_preconfirmed_block branch from 05bf1a3 to 3960c26 Compare May 9, 2026 13:22
@graphite-app graphite-app Bot changed the base branch from graphite-base/13971 to main May 9, 2026 13:23
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented May 9, 2026

Merge activity

  • May 9, 1:23 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue May 9, 2026
Merged via the queue into main with commit f73fbb6 May 9, 2026
23 of 47 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants