central_systest_blobs: implement blob creation from blocks

[dorimedini-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[dorimedini-starkware]

• central_systest_blobs: add proof tx to test privacy feature #14006
• starknet_api: add and use StateRoots::EMPTY #13980
• central_systest_blobs: add some invokes #13978
• central_systest_blobs: support reverting invokes #13977
• central_systest_blobs: implement invoke from deploy function for code sharing #13976
• central_systest_blobs: deploy test contract(s) #13975
• central_systest_blobs: declare the test contract #13974
• central_systest_blobs: expect operator and fee token addresses #13973
• central_systest_blobs: deploy token contract #13972
• central_systest_blobs: sort state diff in preconfirmed block #13971
• central_systest_blobs: deploy operator account #13970
• central_systest_blobs: initial block production #13969
• central_systest_blobs: sort hashsets when dumping #13968
• central_systest_blobs: implement blob creation from blocks #13967 👈 (View in Graphite)
• central_systest_blobs: implement block production, given txs #13966
• blockifier: implement conversion from commitment state diff to state maps #13965
• central_systest_blobs: implement preconfirmed block creation #13964
• central_systest_blobs: first two bootstrap declares #13963
• central_systest_blobs: refactor skeleton into structured factory #13962
• central_systest_blobs: move blobs.json storage out of git, into GCS #13946
• apollo_consensus_orchestrator: add Deserialize for testing #13945
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[cursor]

PR Summary

Medium Risk
Implements real blob/commitment construction logic used by regression tests; mistakes could produce incorrect commitments or blob contents and cause flaky/invalid test fixtures.

Overview
Implements end-to-end blob generation in cende_blob_regression_test.rs by converting finalized BlockData into BlobParameters (including proposal/parent commitments and recent block hashes) and creating AerospikeBlobs via a shared MockClassManagerClient.

finalize() now returns a populated blobs vector for all closed blocks (instead of an empty placeholder) and refactors preconfirmed-block creation to take explicit context/state/tx inputs while improving parent-hash tracking during block closure.

^{Reviewed by Cursor Bugbot for commit ad30ccf. Bugbot is set up for automated code reviews on this repo. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit c0d0ac9. Configure here.}

[dorimedini-starkware]

@dorimedini-starkware resolved 1 discussion.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on nimrod-starkware and yoavGrs).

[nimrod-starkware]

@nimrod-starkware made 4 comments.
Reviewable status: 0 of 1 files reviewed, 4 unresolved discussions (waiting on dorimedini-starkware and yoavGrs).

---

crates/central_systest_blobs/src/cende_blob_regression_test.rs line 132 at r2 (raw file):

impl From<BlockData> for BlobParameters {
    /// If this is not the first block, also sets the parent proposal commitment and populates the
    /// recent block hashes with the last block hash (of the previous block).

Suggestion:

    /// If this is not the first block, also sets the parent proposal commitment and populates the
    /// recent block hashes only with the hash of the previous block.

---

crates/central_systest_blobs/src/cende_blob_regression_test.rs line 134 at r2 (raw file):

    /// recent block hashes with the last block hash (of the previous block).
    fn from(block: BlockData) -> Self {
        let commitment_state_diff = CommitmentStateDiff::from(block.state_maps.clone());

works?

Suggestion:

let commitment_state_diff = CommitmentStateDiff::from(block.state_maps);

---

crates/central_systest_blobs/src/cende_blob_regression_test.rs line 163 at r2 (raw file):

        };

        BlobParameters {

Suggestion:

 Self {

---

crates/central_systest_blobs/src/cende_blob_regression_test.rs line 475 at r2 (raw file):

            transaction_receipts.push(Some(receipt));
            transaction_state_diffs.push(Some(tx_state_diff));
        }

The changes of these txs are not applied on the state (not even between txs), is this intentional?

Code quote:

        for (tx_index, (executable, internal)) in txs.into_iter().enumerate() {
            let tx_hash = match &internal {
                InternalConsensusTransaction::RpcTransaction(tx) => tx.tx_hash,
                InternalConsensusTransaction::L1Handler(_) => {
                    panic!("unexpected L1Handler in test")
                }
            };

            let mut tx_state = CachedState::new(state.clone());
            let execution_info = BlockifierAccountTx::new_for_sequencing(executable)
                .execute(&mut tx_state, &block_context)
                .unwrap();

            let state_changes = tx_state.to_state_diff().unwrap();

            let receipt = StarknetClientTransactionReceipt::from((
                tx_hash,
                TransactionOffsetInBlock(tx_index),
                &execution_info,
                None,
            ));
            let tx_state_diff = StarknetClientStateDiff::from(state_changes.state_maps).0;

            transactions.push(CendePreconfirmedTransaction::from(internal));
            transaction_receipts.push(Some(receipt));
            transaction_state_diffs.push(Some(tx_state_diff));
        }

[dorimedini-starkware]

@dorimedini-starkware made 4 comments.
Reviewable status: 0 of 1 files reviewed, 4 unresolved discussions (waiting on nimrod-starkware and yoavGrs).

---

crates/central_systest_blobs/src/cende_blob_regression_test.rs line 134 at r2 (raw file):

Previously, nimrod-starkware wrote…

works?

no, there is no impl From<&StateMaps> for CommitmentStateDiff, only impl From<StateMaps> for CommitmentStateDiff

---

crates/central_systest_blobs/src/cende_blob_regression_test.rs line 475 at r2 (raw file):

Previously, nimrod-starkware wrote…

The changes of these txs are not applied on the state (not even between txs), is this intentional?

discussed in the PR that added this function, and fixed there (not intentional)

---

crates/central_systest_blobs/src/cende_blob_regression_test.rs line 132 at r2 (raw file):

impl From<BlockData> for BlobParameters {
    /// If this is not the first block, also sets the parent proposal commitment and populates the
    /// recent block hashes with the last block hash (of the previous block).

Done.

---

crates/central_systest_blobs/src/cende_blob_regression_test.rs line 163 at r2 (raw file):

        };

        BlobParameters {

Done.

[nimrod-starkware]

@nimrod-starkware made 2 comments and resolved 2 discussions.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on dorimedini-starkware and yoavGrs).

---

crates/central_systest_blobs/src/cende_blob_regression_test.rs line 132 at r2 (raw file):

Previously, dorimedini-starkware wrote…

Done.

almost :)

---

crates/central_systest_blobs/src/cende_blob_regression_test.rs line 134 at r2 (raw file):

Previously, dorimedini-starkware wrote…

no, there is no impl From<&StateMaps> for CommitmentStateDiff, only impl From<StateMaps> for CommitmentStateDiff

If block is owned (and it is), then block.state_maps type should be StateMaps not &StateMaps... no?

[dorimedini-starkware]

@dorimedini-starkware made 2 comments.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on nimrod-starkware and yoavGrs).

---

crates/central_systest_blobs/src/cende_blob_regression_test.rs line 132 at r2 (raw file):

Previously, nimrod-starkware wrote…

almost :)

whoops :P

---

crates/central_systest_blobs/src/cende_blob_regression_test.rs line 134 at r2 (raw file):

Previously, nimrod-starkware wrote…

If block is owned (and it is), then block.state_maps type should be StateMaps not &StateMaps... no?

right you are, of course!
done

[nimrod-starkware]

@nimrod-starkware reviewed 1 file, made 1 comment, and resolved 2 discussions.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on yoavGrs).

[dorimedini-starkware]

@dorimedini-starkware reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).

[graphite-app]

Merge activity

• May 8, 2:22 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.