Skip to content

central_systest_blobs: implement invoke from deploy function for code sharing#13976

Merged
dorimedini-starkware merged 1 commit into
mainfrom
04-30-central_systest_blobs_implement_invoke_from_deploy_function_for_code_sharing
May 9, 2026
Merged

central_systest_blobs: implement invoke from deploy function for code sharing#13976
dorimedini-starkware merged 1 commit into
mainfrom
04-30-central_systest_blobs_implement_invoke_from_deploy_function_for_code_sharing

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 5, 2026

@cursor
Copy link
Copy Markdown

cursor Bot commented May 5, 2026

PR Summary

Low Risk
Low risk refactor in test data generation that centralizes operator invoke transaction construction; behavior should be unchanged aside from potential calldata composition mistakes.

Overview
Refactors the blob regression test tx builder so operator contract deployment is implemented by calling a new shared helper make_operator_invoke_tx.

make_operator_deploy_tx now only computes the deployed contract_address and deployment calldata, then delegates signing/hashing/queuing of the invoke transaction to the shared helper to reduce duplicated logic.

Reviewed by Cursor Bugbot for commit 97b0feb. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware self-assigned this May 5, 2026
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_deploy_test_contract_s_ branch from 1728354 to d11d08f Compare May 5, 2026 11:18
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_implement_invoke_from_deploy_function_for_code_sharing branch from 3996872 to a433940 Compare May 5, 2026 11:18
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_deploy_test_contract_s_ branch from d11d08f to ee6a2fa Compare May 5, 2026 11:56
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_implement_invoke_from_deploy_function_for_code_sharing branch from a433940 to 33ba948 Compare May 5, 2026 11:56
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_deploy_test_contract_s_ branch from ee6a2fa to 9e4bf26 Compare May 5, 2026 12:31
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_implement_invoke_from_deploy_function_for_code_sharing branch from 33ba948 to 91f2ac3 Compare May 5, 2026 12:31
Copy link
Copy Markdown
Contributor

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@nimrod-starkware reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).

@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_implement_invoke_from_deploy_function_for_code_sharing branch from 91f2ac3 to 8e640b1 Compare May 5, 2026 14:17
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_deploy_test_contract_s_ branch from 9e4bf26 to 499d09c Compare May 5, 2026 14:17
Copy link
Copy Markdown
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).

@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_implement_invoke_from_deploy_function_for_code_sharing branch from 8e640b1 to a2dbf57 Compare May 8, 2026 13:49
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_deploy_test_contract_s_ branch 2 times, most recently from 77df742 to da5621a Compare May 9, 2026 14:12
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_implement_invoke_from_deploy_function_for_code_sharing branch from a2dbf57 to 5aeb699 Compare May 9, 2026 14:12
@graphite-app graphite-app Bot changed the base branch from 04-30-central_systest_blobs_deploy_test_contract_s_ to graphite-base/13976 May 9, 2026 14:47
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_implement_invoke_from_deploy_function_for_code_sharing branch from 5aeb699 to 97b0feb Compare May 9, 2026 16:07
@graphite-app graphite-app Bot changed the base branch from graphite-base/13976 to main May 9, 2026 16:07
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented May 9, 2026

Merge activity

  • May 9, 4:07 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue May 9, 2026
Merged via the queue into main with commit 6a1e2d1 May 9, 2026
20 of 45 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants