Skip to content

central_systest_blobs: deploy test contract(s)#13975

Merged
dorimedini-starkware merged 1 commit into
mainfrom
04-30-central_systest_blobs_deploy_test_contract_s_
May 9, 2026
Merged

central_systest_blobs: deploy test contract(s)#13975
dorimedini-starkware merged 1 commit into
mainfrom
04-30-central_systest_blobs_deploy_test_contract_s_

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 5, 2026

@cursor
Copy link
Copy Markdown

cursor Bot commented May 5, 2026

PR Summary

Low Risk
Changes are limited to systest blob generation and expected JSON fixtures; low production risk, with the main risk being increased test brittleness due to updated golden outputs.

Overview
Updates test_make_data in cende_blob_regression_test.rs to actually deploy two instances of the test contract (fee-charging operator deploys), closing blocks between steps so the deployments are represented in generated data.

Refreshes golden fixtures: bumps resources/blob_file_generation and rewrites resources/preconfirmed_block.json to match the new preconfirmed block contents (block number/timestamp, tx type changing to an INVOKE_FUNCTION deploy call, updated fee/resource usage, and new deployed-contract/state-diff entries).

Reviewed by Cursor Bugbot for commit 3d018d2. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware self-assigned this May 5, 2026
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_deploy_test_contract_s_ branch from 1728354 to d11d08f Compare May 5, 2026 11:18
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_declare_the_test_contract branch from 4985223 to b6a01a6 Compare May 5, 2026 11:18
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_deploy_test_contract_s_ branch from d11d08f to ee6a2fa Compare May 5, 2026 11:56
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_declare_the_test_contract branch from 105ceed to be7907e Compare May 5, 2026 12:31
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_deploy_test_contract_s_ branch from ee6a2fa to 9e4bf26 Compare May 5, 2026 12:31
Copy link
Copy Markdown
Contributor

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nimrod-starkware reviewed 3 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).

@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_deploy_test_contract_s_ branch from 9e4bf26 to 499d09c Compare May 5, 2026 14:17
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_declare_the_test_contract branch from be7907e to 35e9bfe Compare May 5, 2026 14:17
Copy link
Copy Markdown
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).

Copy link
Copy Markdown
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 2 files.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).

@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_deploy_test_contract_s_ branch from 499d09c to 77df742 Compare May 8, 2026 13:49
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_declare_the_test_contract branch 2 times, most recently from 0d169a3 to f6f992f Compare May 9, 2026 14:12
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_deploy_test_contract_s_ branch from 77df742 to da5621a Compare May 9, 2026 14:12
@graphite-app graphite-app Bot changed the base branch from 04-30-central_systest_blobs_declare_the_test_contract to graphite-base/13975 May 9, 2026 14:26
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_deploy_test_contract_s_ branch from da5621a to 3d018d2 Compare May 9, 2026 14:47
@graphite-app graphite-app Bot changed the base branch from graphite-base/13975 to main May 9, 2026 14:47
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented May 9, 2026

Merge activity

  • May 9, 2:47 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue May 9, 2026
Merged via the queue into main with commit 1a1c6c5 May 9, 2026
21 of 45 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants