Skip to content

central_systest_blobs: initial block production#13969

Merged
dorimedini-starkware merged 1 commit into
mainfrom
04-30-central_systest_blobs_initial_block_production
May 9, 2026
Merged

central_systest_blobs: initial block production#13969
dorimedini-starkware merged 1 commit into
mainfrom
04-30-central_systest_blobs_initial_block_production

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 5, 2026

@cursor
Copy link
Copy Markdown

cursor Bot commented May 5, 2026

PR Summary

Medium Risk
Updates the blob regression test to actually execute bootstrap DECLARE transactions and close a block, which changes the expected preconfirmed block and blob generation baseline. Risk is mainly around test fixture churn and potential flakiness if transaction execution or class-manager mocks become non-deterministic.

Overview
The blob regression test now produces real block data by generating and executing bootstrap DECLARE transactions (ERC20 + account-with-real-validate), closing the first block, and leaving remaining txs in the preconfirmed block.

Expected artifacts are updated accordingly: the blobs generation is bumped, and preconfirmed_block.json now reflects block_number: 1 with a populated transaction/receipt/state-diff instead of empty arrays.

Reviewed by Cursor Bugbot for commit 52a8433. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware self-assigned this May 5, 2026
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_sort_hashsets_when_dumping branch from f9cb358 to 24bca91 Compare May 5, 2026 11:18
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_initial_block_production branch from 1f63202 to 76ca51a Compare May 5, 2026 11:18
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_sort_hashsets_when_dumping branch from 24bca91 to caa4531 Compare May 5, 2026 11:56
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_initial_block_production branch from 76ca51a to 8a32ce9 Compare May 5, 2026 11:56
Copy link
Copy Markdown
Contributor

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@nimrod-starkware reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).

@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_sort_hashsets_when_dumping branch from caa4531 to 54e47dc Compare May 5, 2026 12:31
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_initial_block_production branch from 8a32ce9 to 4a1e9a3 Compare May 5, 2026 12:31
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_sort_hashsets_when_dumping branch from 54e47dc to 1b7ea13 Compare May 5, 2026 14:17
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_initial_block_production branch from 4a1e9a3 to 16b1ded Compare May 5, 2026 14:17
Copy link
Copy Markdown
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).

@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_initial_block_production branch from 16b1ded to bba23fa Compare May 8, 2026 13:49
@graphite-app graphite-app Bot changed the base branch from 04-30-central_systest_blobs_sort_hashsets_when_dumping to graphite-base/13969 May 8, 2026 14:40
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_initial_block_production branch from bba23fa to 52a8433 Compare May 9, 2026 08:30
@graphite-app graphite-app Bot changed the base branch from graphite-base/13969 to main May 9, 2026 08:31
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented May 9, 2026

Merge activity

  • May 9, 8:31 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue May 9, 2026
Merged via the queue into main with commit 6d993a5 May 9, 2026
21 of 45 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants