central_systest_blobs: support reverting invokes

[dorimedini-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[dorimedini-starkware]

• central_systest_blobs: add proof tx to test privacy feature #14006
• starknet_api: add and use StateRoots::EMPTY #13980
• central_systest_blobs: add some invokes #13978
• central_systest_blobs: support reverting invokes #13977 👈 (View in Graphite)
• central_systest_blobs: implement invoke from deploy function for code sharing #13976
• central_systest_blobs: deploy test contract(s) #13975
• central_systest_blobs: declare the test contract #13974
• central_systest_blobs: expect operator and fee token addresses #13973
• central_systest_blobs: deploy token contract #13972
• central_systest_blobs: sort state diff in preconfirmed block #13971
• central_systest_blobs: deploy operator account #13970
• central_systest_blobs: initial block production #13969
• central_systest_blobs: sort hashsets when dumping #13968
• central_systest_blobs: implement blob creation from blocks #13967
• central_systest_blobs: implement block production, given txs #13966
• blockifier: implement conversion from commitment state diff to state maps #13965
• central_systest_blobs: implement preconfirmed block creation #13964
• central_systest_blobs: first two bootstrap declares #13963
• central_systest_blobs: refactor skeleton into structured factory #13962
• central_systest_blobs: move blobs.json storage out of git, into GCS #13946
• apollo_consensus_orchestrator: add Deserialize for testing #13945
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[cursor]

PR Summary

Low Risk
Low risk: changes are confined to the blob regression test harness and only relax/clarify assertions around reverted transactions, without affecting production logic.

Overview
Adds per-transaction metadata (TxData) in cende_blob_regression_test.rs to record whether each generated transaction is expected to revert.

Updates block closing and preconfirmed-block generation to assert execution_info.is_reverted() matches should_revert (with clearer index/block diagnostics), and extends make_operator_invoke_tx to accept and propagate the new revert expectation.

^{Reviewed by Cursor Bugbot for commit 32488ba. Bugbot is set up for automated code reviews on this repo. Configure here.}

[nimrod-starkware]

@nimrod-starkware reviewed 1 file and made 2 comments.
Reviewable status: all files reviewed (commit messages unreviewed), 2 unresolved discussions (waiting on dorimedini-starkware and yoavGrs).

---

crates/central_systest_blobs/src/cende_blob_regression_test.rs line 161 at r2 (raw file):

    });

struct TxPair {

please rename
(maybe TxData)

Code quote:

struct TxPair {

---

crates/central_systest_blobs/src/cende_blob_regression_test.rs line 164 at r2 (raw file):

    executable: ExecutableAccountTx,
    internal: InternalConsensusTransaction,
    should_revert: bool,

IMO easier to understand

Suggestion:

should_be_reverted

[dorimedini-starkware]

@dorimedini-starkware made 2 comments.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on nimrod-starkware and yoavGrs).

---

crates/central_systest_blobs/src/cende_blob_regression_test.rs line 161 at r2 (raw file):

Previously, nimrod-starkware wrote…

please rename
(maybe TxData)

Done.

---

crates/central_systest_blobs/src/cende_blob_regression_test.rs line 164 at r2 (raw file):

Previously, nimrod-starkware wrote…

IMO easier to understand

revert is a verb, I think the current name works well ("should the tx revert?")

[nimrod-starkware]

@nimrod-starkware reviewed 1 file and all commit messages, and resolved 2 discussions.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).

[nimrod-starkware]

@nimrod-starkware made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 92a3d78. Configure here.}

[dorimedini-starkware]

@dorimedini-starkware resolved 1 discussion.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on nimrod-starkware and yoavGrs).

[dorimedini-starkware]

@dorimedini-starkware reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on nimrod-starkware and yoavGrs).

[nimrod-starkware]

@nimrod-starkware reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on dorimedini-starkware and yoavGrs).

---

crates/central_systest_blobs/src/cende_blob_regression_test.rs line 715 at r5 (raw file):

                "Execution result does not match expected (should_revert={should_revert}): \
                 {execution_info:?}"
            );

Consider adding some information about the tx to the error message, will make debug easier...

Suggestion:

            assert_eq!(
                execution_info.is_reverted(),
                should_revert,
                "Transaction {tx:?} result does not match expected (should_revert={should_revert}): \
                 {execution_info:?}"
            );

[dorimedini-starkware]

@dorimedini-starkware made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on nimrod-starkware and yoavGrs).

---

crates/central_systest_blobs/src/cende_blob_regression_test.rs line 715 at r5 (raw file):

Previously, nimrod-starkware wrote…

Consider adding some information about the tx to the error message, will make debug easier...

Done.

[nimrod-starkware]

@nimrod-starkware reviewed 1 file and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).