Skip to content

central_systest_blobs: expect operator and fee token addresses#13973

Merged
dorimedini-starkware merged 1 commit into
mainfrom
04-30-central_systest_blobs_expect_operator_and_fee_token_addresses
May 9, 2026
Merged

central_systest_blobs: expect operator and fee token addresses#13973
dorimedini-starkware merged 1 commit into
mainfrom
04-30-central_systest_blobs_expect_operator_and_fee_token_addresses

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 5, 2026

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review May 5, 2026 11:05
@cursor
Copy link
Copy Markdown

cursor Bot commented May 5, 2026

PR Summary

Low Risk
Low risk: changes are limited to test/data fixtures and blob generation expectations, with no production logic changes.

Overview
Tightens the central_systest_blobs regression test by making the operator and fee token contract addresses deterministic and explicitly asserted, and by wiring these addresses into ChainInfo fee token configuration.

Updates the expected fixtures (chain_info.json, preconfirmed_block.json) and bumps the stored blob generation to reflect the new deterministic addresses and resulting receipt/gas deltas.

Reviewed by Cursor Bugbot for commit 0e3536c. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware self-assigned this May 5, 2026
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_expect_operator_and_fee_token_addresses branch from da7b263 to 7e39626 Compare May 5, 2026 11:18
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_deploy_token_contract branch from 1c6a757 to 05c3328 Compare May 5, 2026 11:18
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_deploy_token_contract branch from 05c3328 to b7db825 Compare May 5, 2026 11:56
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_expect_operator_and_fee_token_addresses branch from 7e39626 to 742c842 Compare May 5, 2026 11:56
Copy link
Copy Markdown
Contributor

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@nimrod-starkware reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).

@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_deploy_token_contract branch from b7db825 to f831a9b Compare May 5, 2026 12:31
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_expect_operator_and_fee_token_addresses branch 2 times, most recently from 9714281 to 230aacb Compare May 5, 2026 14:17
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_deploy_token_contract branch from f831a9b to 0f8511a Compare May 5, 2026 14:17
Copy link
Copy Markdown
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).

@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_deploy_token_contract branch from 0f8511a to a390a37 Compare May 8, 2026 13:49
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_expect_operator_and_fee_token_addresses branch from 230aacb to 65eba15 Compare May 8, 2026 13:49
@graphite-app graphite-app Bot changed the base branch from 04-30-central_systest_blobs_deploy_token_contract to graphite-base/13973 May 9, 2026 13:52
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_expect_operator_and_fee_token_addresses branch from 65eba15 to 0e3536c Compare May 9, 2026 14:10
@graphite-app graphite-app Bot changed the base branch from graphite-base/13973 to main May 9, 2026 14:11
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented May 9, 2026

Merge activity

  • May 9, 2:11 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue May 9, 2026
Merged via the queue into main with commit c391b88 May 9, 2026
20 of 45 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants