Skip to content

central_systest_blobs: declare the test contract#13974

Merged
dorimedini-starkware merged 1 commit into
mainfrom
04-30-central_systest_blobs_declare_the_test_contract
May 9, 2026
Merged

central_systest_blobs: declare the test contract#13974
dorimedini-starkware merged 1 commit into
mainfrom
04-30-central_systest_blobs_declare_the_test_contract

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 5, 2026

@cursor
Copy link
Copy Markdown

cursor Bot commented May 5, 2026

PR Summary

Low Risk
Changes are limited to systest blob generation logic and its golden outputs; main risk is breaking blob regression expectations due to updated transaction hashing/signing and fee/resource-bounds in generated fixtures.

Overview
Updates the blob regression test to support generating both bootstrap declares and regular fee-paying DECLARE transactions via a new make_declare_tx(..., sender) helper (signing and using NON_TRIVIAL_RESOURCE_BOUNDS when a sender is provided).

Extends the test_make_data flow to include declaring the TestContract from the operator account (non-bootstrap), and refreshes the checked-in fixtures (preconfirmed_block.json) plus bumps the blob generation id (resources/blob_file_generation).

Reviewed by Cursor Bugbot for commit 30f0de8. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware self-assigned this May 5, 2026
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_declare_the_test_contract branch from 4985223 to b6a01a6 Compare May 5, 2026 11:18
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_expect_operator_and_fee_token_addresses branch from 7e39626 to 742c842 Compare May 5, 2026 11:56
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_declare_the_test_contract branch 2 times, most recently from 105ceed to be7907e Compare May 5, 2026 12:31
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_expect_operator_and_fee_token_addresses branch from 742c842 to 9714281 Compare May 5, 2026 12:31
Copy link
Copy Markdown
Contributor

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@nimrod-starkware reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).

@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_expect_operator_and_fee_token_addresses branch from 9714281 to 230aacb Compare May 5, 2026 14:17
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_declare_the_test_contract branch from be7907e to 35e9bfe Compare May 5, 2026 14:17
Copy link
Copy Markdown
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).

@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_expect_operator_and_fee_token_addresses branch from 230aacb to 65eba15 Compare May 8, 2026 13:49
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_declare_the_test_contract branch from 35e9bfe to 0d169a3 Compare May 8, 2026 13:49
@graphite-app graphite-app Bot changed the base branch from 04-30-central_systest_blobs_expect_operator_and_fee_token_addresses to graphite-base/13974 May 9, 2026 14:10
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_declare_the_test_contract branch from 0d169a3 to f6f992f Compare May 9, 2026 14:12
@dorimedini-starkware dorimedini-starkware changed the base branch from graphite-base/13974 to 04-30-central_systest_blobs_expect_operator_and_fee_token_addresses May 9, 2026 14:12
@ilyalesokhin-starkware ilyalesokhin-starkware changed the base branch from 04-30-central_systest_blobs_expect_operator_and_fee_token_addresses to main May 9, 2026 14:25
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_declare_the_test_contract branch from f6f992f to 30f0de8 Compare May 9, 2026 14:26
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented May 9, 2026

Merge activity

  • May 9, 2:26 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue May 9, 2026
Merged via the queue into main with commit 56bccd9 May 9, 2026
16 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants