Skip to content

central_systest_blobs: add some invokes#13978

Merged
dorimedini-starkware merged 2 commits into
mainfrom
04-30-central_systest_blobs_add_some_invokes
May 10, 2026
Merged

central_systest_blobs: add some invokes#13978
dorimedini-starkware merged 2 commits into
mainfrom
04-30-central_systest_blobs_add_some_invokes

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 5, 2026

@cursor
Copy link
Copy Markdown

cursor Bot commented May 5, 2026

PR Summary

Low Risk
Changes are limited to system-test blob generation and golden test fixtures; primary risk is increased test brittleness due to updated expected blob/preconfirmed-block outputs.

Overview
Updates the central_systest_blobs regression-data generator to include a richer sequence of operator INVOKE_FUNCTION transactions (including storage reads/writes, a reverting call, a cross-contract call using selector_from_name, and a revert-catching scenario), with additional block closes to keep the final preconfirmed block non-empty.

Bumps the blobs fixture generation (resources/blob_file_generation) and refreshes the golden resources/preconfirmed_block.json to match the new transaction sequence (new block number/timestamp, tx hash/nonce, fees, and state diffs).

Reviewed by Cursor Bugbot for commit 80bb904. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit e8ac2ca. Configure here.

Comment thread crates/central_systest_blobs/src/cende_blob_regression_test.rs
@dorimedini-starkware dorimedini-starkware force-pushed the 05-05-central_systest_blobs_support_reverting_invokes branch from 556eda2 to c05cd6d Compare May 5, 2026 11:18
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_add_some_invokes branch from e8ac2ca to 85cd564 Compare May 5, 2026 11:18
Copy link
Copy Markdown
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware resolved 1 discussion.
Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on nimrod-starkware and yoavGrs).

@dorimedini-starkware dorimedini-starkware force-pushed the 05-05-central_systest_blobs_support_reverting_invokes branch from c05cd6d to c2b98b3 Compare May 5, 2026 11:56
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_add_some_invokes branch 2 times, most recently from 8bde747 to c9a7ca9 Compare May 5, 2026 12:31
Copy link
Copy Markdown
Contributor

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nimrod-starkware reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on dorimedini-starkware and yoavGrs).


crates/central_systest_blobs/src/cende_blob_regression_test.rs line 920 at r2 (raw file):

        &[Felt::from(7u8), Felt::ONE],
        true, // charge fee
        true, // should revert

Suggestion:

should be reverted

@dorimedini-starkware dorimedini-starkware force-pushed the 05-05-central_systest_blobs_support_reverting_invokes branch from 4b81e80 to ac488b5 Compare May 5, 2026 12:41
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_add_some_invokes branch from c9a7ca9 to 015017d Compare May 5, 2026 12:41
Copy link
Copy Markdown
Contributor

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@nimrod-starkware reviewed 1 file and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).

Copy link
Copy Markdown
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).


crates/central_systest_blobs/src/cende_blob_regression_test.rs line 920 at r2 (raw file):

        &[Felt::from(7u8), Felt::ONE],
        true, // charge fee
        true, // should revert

see previous PR: revert is a verb, I think this is fine

@dorimedini-starkware dorimedini-starkware force-pushed the 05-05-central_systest_blobs_support_reverting_invokes branch from ac488b5 to 92a3d78 Compare May 5, 2026 14:17
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_add_some_invokes branch 2 times, most recently from 3700e92 to fd1c2e9 Compare May 5, 2026 14:23
@dorimedini-starkware dorimedini-starkware force-pushed the 05-05-central_systest_blobs_support_reverting_invokes branch 2 times, most recently from 735123b to 9515fd3 Compare May 8, 2026 13:49
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_add_some_invokes branch 2 times, most recently from 9f74247 to 6e16f47 Compare May 9, 2026 14:12
@dorimedini-starkware dorimedini-starkware force-pushed the 05-05-central_systest_blobs_support_reverting_invokes branch from 9515fd3 to 103c6c9 Compare May 9, 2026 14:12
@dorimedini-starkware dorimedini-starkware force-pushed the 05-05-central_systest_blobs_support_reverting_invokes branch from 103c6c9 to fec2ba9 Compare May 9, 2026 18:52
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_add_some_invokes branch from 6e16f47 to 1aa8f60 Compare May 9, 2026 18:52
Copy link
Copy Markdown
Contributor

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nimrod-starkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).

@dorimedini-starkware dorimedini-starkware force-pushed the 05-05-central_systest_blobs_support_reverting_invokes branch from fec2ba9 to 32488ba Compare May 10, 2026 06:42
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_add_some_invokes branch from 1aa8f60 to 80bb904 Compare May 10, 2026 06:42
@dorimedini-starkware dorimedini-starkware changed the base branch from 05-05-central_systest_blobs_support_reverting_invokes to main May 10, 2026 07:18
Copy link
Copy Markdown
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 3 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue May 10, 2026
Merged via the queue into main with commit 10a76d2 May 10, 2026
29 of 42 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants