Skip to content

central_systest_blobs: deploy token contract#13972

Merged
dorimedini-starkware merged 1 commit into
mainfrom
04-30-central_systest_blobs_deploy_token_contract
May 9, 2026
Merged

central_systest_blobs: deploy token contract#13972
dorimedini-starkware merged 1 commit into
mainfrom
04-30-central_systest_blobs_deploy_token_contract

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 5, 2026

@cursor
Copy link
Copy Markdown

cursor Bot commented May 5, 2026

PR Summary

Low Risk
Changes are confined to test data generation and golden fixtures; main risk is brittle expectation updates causing CI failures if transaction encoding/nonce handling differs across environments or versions.

Overview
Updates the central_systest_blobs regression dataset to include an operator-driven deployment of an ERC20 token contract after the operator account is deployed.

The test harness now tracks account nonces via NonceManager, adds helpers to build/sign an INVOKE multicall (with optional non-trivial resource bounds), and refreshes the expected preconfirmed_block.json plus bumps the blobs generation counter.

Reviewed by Cursor Bugbot for commit b79489f. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware self-assigned this May 5, 2026
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_sort_state_diff_in_preconfirmed_block branch from 694fc71 to 9672f60 Compare May 5, 2026 11:18
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_deploy_token_contract branch from 1c6a757 to 05c3328 Compare May 5, 2026 11:18
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_deploy_token_contract branch from 05c3328 to b7db825 Compare May 5, 2026 11:56
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_sort_state_diff_in_preconfirmed_block branch from 9672f60 to b04d116 Compare May 5, 2026 11:56
Copy link
Copy Markdown
Contributor

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@nimrod-starkware reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).

@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_deploy_token_contract branch from b7db825 to f831a9b Compare May 5, 2026 12:31
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_sort_state_diff_in_preconfirmed_block branch from 12e4044 to 0e28d9e Compare May 5, 2026 14:17
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_deploy_token_contract branch from f831a9b to 0f8511a Compare May 5, 2026 14:17
Copy link
Copy Markdown
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).

@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_deploy_token_contract branch from 0f8511a to a390a37 Compare May 8, 2026 13:49
@graphite-app graphite-app Bot changed the base branch from 04-30-central_systest_blobs_sort_state_diff_in_preconfirmed_block to graphite-base/13972 May 9, 2026 13:22
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_deploy_token_contract branch from a390a37 to b79489f Compare May 9, 2026 13:52
@graphite-app graphite-app Bot changed the base branch from graphite-base/13972 to main May 9, 2026 13:53
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented May 9, 2026

Merge activity

  • May 9, 1:53 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue May 9, 2026
Merged via the queue into main with commit a9f8b45 May 9, 2026
20 of 45 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants