Skip to content

workspace,starknet_proof_verifier: bump privacy-{prove,circuit-verify} to 69ed219, add legacy alias#14017

Open
Yoni-Starkware wants to merge 1 commit into
05-10-starknet_proof_verifier_add_v0.14.3_regression_case_for_proof_version_v1_fixturefrom
05-10-workspace_starknet_proof_verifier_bump_privacy-prove_and_privacy-circuit-verify_to_69ed219_add_legacy_alias_dispatch_v0_to_legacy
Open

workspace,starknet_proof_verifier: bump privacy-{prove,circuit-verify} to 69ed219, add legacy alias#14017
Yoni-Starkware wants to merge 1 commit into
05-10-starknet_proof_verifier_add_v0.14.3_regression_case_for_proof_version_v1_fixturefrom
05-10-workspace_starknet_proof_verifier_bump_privacy-prove_and_privacy-circuit-verify_to_69ed219_add_legacy_alias_dispatch_v0_to_legacy

Conversation

@Yoni-Starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@cursor
Copy link
Copy Markdown

cursor Bot commented May 10, 2026

PR Summary

Medium Risk
Updates the proof verification/proving dependency graph to new upstream git revisions and changes runtime dispatch between legacy/current verifiers based on proof version, which could affect consensus-critical proof validation behavior.

Overview
Bumps privacy-{circuit-verify,prove} (and related stwo*/circuit crates via Cargo.lock) to a newer upstream revision, pulling in updated circuit/verifier dependencies.

Adds a privacy-circuit-verify-legacy workspace dependency pinned to the previous revision, and updates starknet_proof_verifier::verify_proof to route V0 proofs to the legacy verifier while routing V1 proofs to the updated verifier.

Reviewed by Cursor Bugbot for commit 85967fb. Bugbot is set up for automated code reviews on this repo. Configure here.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-workspace_starknet_proof_verifier_bump_privacy-prove_and_privacy-circuit-verify_to_69ed219_add_legacy_alias_dispatch_v0_to_legacy branch from d445589 to 845affe Compare May 11, 2026 06:34
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-starknet_proof_verifier_add_v0.14.3_regression_case_for_proof_version_v1_fixture branch from 6ac567b to 963202d Compare May 11, 2026 06:34
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-workspace_starknet_proof_verifier_bump_privacy-prove_and_privacy-circuit-verify_to_69ed219_add_legacy_alias_dispatch_v0_to_legacy branch from 845affe to bd31b43 Compare May 11, 2026 07:23
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-starknet_proof_verifier_add_v0.14.3_regression_case_for_proof_version_v1_fixture branch 2 times, most recently from 1a88611 to ef43d9f Compare May 11, 2026 07:30
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-workspace_starknet_proof_verifier_bump_privacy-prove_and_privacy-circuit-verify_to_69ed219_add_legacy_alias_dispatch_v0_to_legacy branch 2 times, most recently from b4fb627 to afe1573 Compare May 11, 2026 07:32
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-starknet_proof_verifier_add_v0.14.3_regression_case_for_proof_version_v1_fixture branch from ef43d9f to 67dfc82 Compare May 11, 2026 07:32
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-workspace_starknet_proof_verifier_bump_privacy-prove_and_privacy-circuit-verify_to_69ed219_add_legacy_alias_dispatch_v0_to_legacy branch from afe1573 to f09af06 Compare May 11, 2026 07:33
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-starknet_proof_verifier_add_v0.14.3_regression_case_for_proof_version_v1_fixture branch from 67dfc82 to 430f38c Compare May 11, 2026 07:33
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-workspace_starknet_proof_verifier_bump_privacy-prove_and_privacy-circuit-verify_to_69ed219_add_legacy_alias_dispatch_v0_to_legacy branch from f09af06 to dc465e6 Compare May 11, 2026 07:55
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-starknet_proof_verifier_add_v0.14.3_regression_case_for_proof_version_v1_fixture branch 3 times, most recently from 42bbbd4 to c5110f2 Compare May 11, 2026 11:49
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-workspace_starknet_proof_verifier_bump_privacy-prove_and_privacy-circuit-verify_to_69ed219_add_legacy_alias_dispatch_v0_to_legacy branch from dc465e6 to a274215 Compare May 11, 2026 11:49
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-workspace_starknet_proof_verifier_bump_privacy-prove_and_privacy-circuit-verify_to_69ed219_add_legacy_alias_dispatch_v0_to_legacy branch from a274215 to 85967fb Compare May 11, 2026 12:03
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-starknet_proof_verifier_add_v0.14.3_regression_case_for_proof_version_v1_fixture branch from c5110f2 to 6e47d4b Compare May 11, 2026 12:03
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 85967fb. Configure here.

privacy_circuit_verify::verify_recursive_circuit(&proof_output)
.map_err(|e| VerifyProofError::Verification(e.to_string()))?;
}
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

V1 regression test data incompatible with new verifier

Medium Severity

The version dispatch now routes ProofVersion::V1 to the new privacy-circuit-verify (rev 69ed219), but the existing 0.14.3 regression test data contains V1 proof facts with a proof generated by the old prover/circuit (rev 580135e). Since try_into_proof_facts always stamps ProofVersion::V1, all proofs produced between the V1 introduction and this circuit bump carry V1 but are only valid against the old circuit. The 0.14.3 regression test will likely fail, and any in-flight V1 proofs from the previous prover version would also fail verification in production during the upgrade window.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 85967fb. Configure here.

Copy link
Copy Markdown
Contributor

@AvivYossef-starkware AvivYossef-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be in a different PR, but I think we need to add cases for virtual snos prover test (round-trip proving and verifying in the CI) .
and maybe change/add cases to the os tests for tx with proof facts

@AvivYossef-starkware reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status: 4 of 6 files reviewed, 1 unresolved discussion (waiting on Yoni-Starkware).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants