workspace,starknet_proof_verifier: bump privacy-{prove,circuit-verify} to 69ed219, add legacy alias#14017
Conversation
PR SummaryMedium Risk Overview Adds a Reviewed by Cursor Bugbot for commit 85967fb. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Artifacts upload workflows: |
d445589 to
845affe
Compare
6ac567b to
963202d
Compare
845affe to
bd31b43
Compare
1a88611 to
ef43d9f
Compare
b4fb627 to
afe1573
Compare
ef43d9f to
67dfc82
Compare
afe1573 to
f09af06
Compare
67dfc82 to
430f38c
Compare
f09af06 to
dc465e6
Compare
42bbbd4 to
c5110f2
Compare
dc465e6 to
a274215
Compare
…} to 69ed219, add legacy alias
a274215 to
85967fb
Compare
c5110f2 to
6e47d4b
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 85967fb. Configure here.
| privacy_circuit_verify::verify_recursive_circuit(&proof_output) | ||
| .map_err(|e| VerifyProofError::Verification(e.to_string()))?; | ||
| } | ||
| } |
There was a problem hiding this comment.
V1 regression test data incompatible with new verifier
Medium Severity
The version dispatch now routes ProofVersion::V1 to the new privacy-circuit-verify (rev 69ed219), but the existing 0.14.3 regression test data contains V1 proof facts with a proof generated by the old prover/circuit (rev 580135e). Since try_into_proof_facts always stamps ProofVersion::V1, all proofs produced between the V1 introduction and this circuit bump carry V1 but are only valid against the old circuit. The 0.14.3 regression test will likely fail, and any in-flight V1 proofs from the previous prover version would also fail verification in production during the upgrade window.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 85967fb. Configure here.
AvivYossef-starkware
left a comment
There was a problem hiding this comment.
Can be in a different PR, but I think we need to add cases for virtual snos prover test (round-trip proving and verifying in the CI) .
and maybe change/add cases to the os tests for tx with proof facts
@AvivYossef-starkware reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status: 4 of 6 files reviewed, 1 unresolved discussion (waiting on Yoni-Starkware).



No description provided.