Skip to content

starknet_api,starknet_proof_verifier: write PROOF_VERSION_V1 in try_into_proof_facts#14015

Open
Yoni-Starkware wants to merge 1 commit into
05-10-apollo_starknet_os_program_starknet_os_support_proof_version_v1_in_check_proof_factsfrom
05-10-starknet_api_starknet_proof_verifier_write_proof_version_v1_in_try_into_proof_facts
Open

starknet_api,starknet_proof_verifier: write PROOF_VERSION_V1 in try_into_proof_facts#14015
Yoni-Starkware wants to merge 1 commit into
05-10-apollo_starknet_os_program_starknet_os_support_proof_version_v1_in_check_proof_factsfrom
05-10-starknet_api_starknet_proof_verifier_write_proof_version_v1_in_try_into_proof_facts

Conversation

@Yoni-Starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@cursor
Copy link
Copy Markdown

cursor Bot commented May 10, 2026

PR Summary

Medium Risk
Changes the proof-facts version marker from V0 to V1 when converting bootloader output, which can break consumers that still assume V0 and could affect proof verification interoperability.

Overview
Updates ProgramOutput::try_into_proof_facts to write ProofVersion::V1 (instead of V0) as the leading marker in generated ProofFacts, aligning newly produced proof facts with the current proof version.

Adjusts documentation/comments and the roundtrip unit test to expect V1, and loosens reconstruct_output_preimage wording to treat the first element generically as PROOF_VERSION_V*.

Reviewed by Cursor Bugbot for commit f2620df. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions
Copy link
Copy Markdown

Artifacts upload workflows:

@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-apollo_starknet_os_program_starknet_os_support_proof_version_v1_in_check_proof_facts branch from af28490 to 39b9d56 Compare May 10, 2026 17:01
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-starknet_api_starknet_proof_verifier_write_proof_version_v1_in_try_into_proof_facts branch from 26be1cf to 331d1e2 Compare May 10, 2026 17:01
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-apollo_starknet_os_program_starknet_os_support_proof_version_v1_in_check_proof_facts branch from 39b9d56 to d0f4a98 Compare May 11, 2026 06:34
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-starknet_api_starknet_proof_verifier_write_proof_version_v1_in_try_into_proof_facts branch from 331d1e2 to bd5effd Compare May 11, 2026 06:34
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-apollo_starknet_os_program_starknet_os_support_proof_version_v1_in_check_proof_facts branch from d0f4a98 to d72bed0 Compare May 11, 2026 07:23
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-starknet_api_starknet_proof_verifier_write_proof_version_v1_in_try_into_proof_facts branch 2 times, most recently from f8d1581 to f5f61b8 Compare May 11, 2026 07:30
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-apollo_starknet_os_program_starknet_os_support_proof_version_v1_in_check_proof_facts branch from c496f63 to 04f95dd Compare May 11, 2026 07:32
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-starknet_api_starknet_proof_verifier_write_proof_version_v1_in_try_into_proof_facts branch 2 times, most recently from 03c92c6 to b9bf614 Compare May 11, 2026 07:33
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-apollo_starknet_os_program_starknet_os_support_proof_version_v1_in_check_proof_facts branch 2 times, most recently from 558f5fc to 8436836 Compare May 11, 2026 07:55
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-starknet_api_starknet_proof_verifier_write_proof_version_v1_in_try_into_proof_facts branch 2 times, most recently from 23c4d2f to 872e8c6 Compare May 11, 2026 11:35
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-apollo_starknet_os_program_starknet_os_support_proof_version_v1_in_check_proof_facts branch from 8436836 to 693e3ee Compare May 11, 2026 11:35
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 872e8c6. Configure here.

Comment thread crates/starknet_proof_verifier/src/proof_verifier.rs
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-apollo_starknet_os_program_starknet_os_support_proof_version_v1_in_check_proof_facts branch from 693e3ee to 4ffdb3c Compare May 11, 2026 11:49
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-starknet_api_starknet_proof_verifier_write_proof_version_v1_in_try_into_proof_facts branch from 872e8c6 to 51df181 Compare May 11, 2026 11:49
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-starknet_api_starknet_proof_verifier_write_proof_version_v1_in_try_into_proof_facts branch from 51df181 to f2620df Compare May 11, 2026 12:03
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-apollo_starknet_os_program_starknet_os_support_proof_version_v1_in_check_proof_facts branch from 4ffdb3c to 46e192d Compare May 11, 2026 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants