Skip to content

starknet_api,starknet_proof_verifier: rename PROOF_VERSION to PROOF_VERSION_V0#14011

Merged
Yoni-Starkware merged 1 commit into
mainfrom
05-10-starknet_api_starknet_proof_verifier_rename_proof_version_to_proof_version_v0
May 11, 2026
Merged

starknet_api,starknet_proof_verifier: rename PROOF_VERSION to PROOF_VERSION_V0#14011
Yoni-Starkware merged 1 commit into
mainfrom
05-10-starknet_api_starknet_proof_verifier_rename_proof_version_to_proof_version_v0

Conversation

@Yoni-Starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@cursor
Copy link
Copy Markdown

cursor Bot commented May 10, 2026

PR Summary

Low Risk
Low functional risk since the proof version value and validation behavior are unchanged; main risk is a compile-time breaking API rename for any downstream code still importing PROOF_VERSION.

Overview
Renames the proof-facts version marker constant from PROOF_VERSION to PROOF_VERSION_V0 across starknet_api and updates all call sites (test utilities, proof-facts parsing/validation, and the proof verifier).

Test assertions and error messages/docs were adjusted to reference PROOF_VERSION_V0, keeping the proof-facts format and expected marker value ('PROOF0') the same.

Reviewed by Cursor Bugbot for commit 69ce1ec. Bugbot is set up for automated code reviews on this repo. Configure here.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@github-actions
Copy link
Copy Markdown

Artifacts upload workflows:

Copy link
Copy Markdown
Contributor

@AvivYossef-starkware AvivYossef-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@AvivYossef-starkware reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Yoni-Starkware).

@Yoni-Starkware Yoni-Starkware added this pull request to the merge queue May 11, 2026
Merged via the queue into main with commit 54e2cbf May 11, 2026
30 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants