starknet_proof_verifier: accept either PROOF_VERSION_V0 or PROOF_VERSION_V1 in verify_proof

[Yoni-Starkware]

No description provided.

[cursor]

PR Summary

Medium Risk
Touches proof verification gating logic by widening accepted ProofFacts version markers to include V1, which could change which proofs are accepted or rejected. While the verifier circuit call is unchanged, mistakes here impact a security-critical validation boundary.

Overview
Updates verify_proof to accept either ProofVersion::V0 or ProofVersion::V1 by parsing the first felt via ProofFacts::proof_version_felt()/ProofVersion::try_from instead of hard-rejecting anything not equal to PROOF_VERSION_V0.

Refactors related constants/error reporting: ProgramOutput::try_into_proof_facts now writes the version marker via ProofVersion::V0.as_felt(), and VerifyProofError::InvalidProofVersion is simplified to report the unsupported actual value (with an error message listing V0/V1).

^{Reviewed by Cursor Bugbot for commit 8a42f7c. Bugbot is set up for automated code reviews on this repo. Configure here.}

[reviewable-StarkWare]

This change is 

[Yoni-Starkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• workspace,starknet_proof_verifier: bump privacy-{prove,circuit-verify} to 69ed219, add legacy alias #14017
• starknet_proof_verifier: add v0.14.3 regression case for PROOF_VERSION_V1 fixture #14016
• starknet_api,starknet_proof_verifier: write PROOF_VERSION_V1 in try_into_proof_facts #14015
• apollo_starknet_os_program,starknet_os: support PROOF_VERSION_V1 in check_proof_facts #14014
• starknet_proof_verifier: accept either PROOF_VERSION_V0 or PROOF_VERSION_V1 in verify_proof #14013 👈 (View in Graphite)
• starknet_api: add PROOF_VERSION_V1 and accept either marker in ProofFactsVariant #14012
• starknet_api,starknet_proof_verifier: rename PROOF_VERSION to PROOF_VERSION_V0 #14011
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[AvivYossef-starkware]

@AvivYossef-starkware reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on Yoni-Starkware).

---

crates/starknet_proof_verifier/src/proof_verifier.rs line 132 at r1 (raw file):

    }

    let proof_version = proof_facts.0.first().copied().unwrap_or_default();

plz extract it to a function proof_fact.proof_version()

Code quote:

proof_facts.0.first()

[AvivYossef-starkware]

@AvivYossef-starkware reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on Yoni-Starkware).

---

crates/starknet_proof_verifier/src/proof_verifier.rs line 25 at r2 (raw file):

        v1_felt = ProofVersion::V1.as_felt(),
        v1_str = ProofVersion::V1.as_str(),
    )]

consider impl debug / display that shows both str and felt

Code quote:

        "Unsupported proof version: got {actual}, expected {v0_felt} ({v0_str}) or {v1_felt} \
         ({v1_str}).",
        v0_felt = ProofVersion::V0.as_felt(),
        v0_str = ProofVersion::V0.as_str(),
        v1_felt = ProofVersion::V1.as_felt(),
        v1_str = ProofVersion::V1.as_str(),
    )]

[Yoni-Starkware]

@Yoni-Starkware made 1 comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on AvivYossef-starkware).

---

crates/starknet_proof_verifier/src/proof_verifier.rs line 25 at r2 (raw file):

Previously, AvivYossef-starkware wrote…

consider impl debug / display that shows both str and felt

Thanks, done

[AvivYossef-starkware]

@AvivYossef-starkware reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on Yoni-Starkware).