apollo_starknet_os_program,starknet_os: support PROOF_VERSION_V1 in check_proof_facts

[Yoni-Starkware]

No description provided.

[cursor]

PR Summary

Medium Risk
Touches Cairo-level proof-facts validation and updates the compiled OS program hash, which could affect which proofs/transactions are accepted if constants or hashing are wrong.

Overview
Updates check_proof_facts to explicitly validate proof_variant and accept either PROOF_VERSION_V0 (legacy) or PROOF_VERSION_V1 with a clearer error message, instead of requiring an exact header match.

Renames the Cairo constant PROOF_VERSION to PROOF_VERSION_V0, introduces PROOF_VERSION_V1, wires both through the Rust constant fetcher (Const) and tests, and updates the OS program hash and expected OS bytecode length accordingly.

^{Reviewed by Cursor Bugbot for commit 46e192d. Bugbot is set up for automated code reviews on this repo. Configure here.}

[reviewable-StarkWare]

This change is 

[Yoni-Starkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• workspace,starknet_proof_verifier: bump privacy-{prove,circuit-verify} to 69ed219, add legacy alias #14017
• starknet_proof_verifier: add v0.14.3 regression case for PROOF_VERSION_V1 fixture #14016
• starknet_api,starknet_proof_verifier: write PROOF_VERSION_V1 in try_into_proof_facts #14015
• apollo_starknet_os_program,starknet_os: support PROOF_VERSION_V1 in check_proof_facts #14014 👈 (View in Graphite)
• starknet_proof_verifier: accept either PROOF_VERSION_V0 or PROOF_VERSION_V1 in verify_proof #14013
• starknet_api: add PROOF_VERSION_V1 and accept either marker in ProofFactsVariant #14012
• starknet_api,starknet_proof_verifier: rename PROOF_VERSION to PROOF_VERSION_V0 #14011
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Yoni-Starkware]

@Yoni-Starkware made 1 comment.
Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion.

---

crates/apollo_starknet_os_program/src/cairo/starkware/starknet/core/os/execution/execution_constraints.cairo line 57 at r1 (raw file):

        tempvar v1_diff = proof_header.proof_version - PROOF_VERSION_V1;
        assert v0_diff * v1_diff = 0;
    }

Suggestion:

    // Validate the proof header.
    static_assert ProofHeader.SIZE == 3;
    let proof_header = cast(proof_facts, ProofHeader*);
    assert proof_header.proof_variant = VIRTUAL_SNOS;
    assert is_program_hash_allowed(proof_header.program_hash) = TRUE;
    // Proof variant must be VIRTUAL_SNOS; proof version may be V0 (legacy) or V1 (current).
    with_attr error_message("Unsupported proof version") {
        tempvar proof_version = proof_header.proof_version;
        assert (proof_version - PROOF_VERSION_V1) * (proof_version - PROOF_VERSION_V1) = 0;
    }

[AvivYossef-starkware]

@AvivYossef-starkware reviewed 6 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion.