Skip to content

starknet_proof_verifier: add v0.14.3 regression case for PROOF_VERSION_V1 fixture#14016

Open
Yoni-Starkware wants to merge 1 commit into
05-10-starknet_api_starknet_proof_verifier_write_proof_version_v1_in_try_into_proof_factsfrom
05-10-starknet_proof_verifier_add_v0.14.3_regression_case_for_proof_version_v1_fixture
Open

starknet_proof_verifier: add v0.14.3 regression case for PROOF_VERSION_V1 fixture#14016
Yoni-Starkware wants to merge 1 commit into
05-10-starknet_api_starknet_proof_verifier_write_proof_version_v1_in_try_into_proof_factsfrom
05-10-starknet_proof_verifier_add_v0.14.3_regression_case_for_proof_version_v1_fixture

Conversation

@Yoni-Starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@cursor
Copy link
Copy Markdown

cursor Bot commented May 10, 2026

PR Summary

Low Risk
Low risk: updates test fixtures and expands regression coverage without changing verifier logic or production code paths.

Overview
Adds a new regression fixture set for Starknet 0.14.3 (including example_proof_facts.json) and extends the regression_verify_proof_from_old_prover rstest to run against it.

Updates the shared apollo_transaction_converter example_proof_facts.json to use PROOF_VERSION_V1 (0x50524f4f4631) instead of the previous version value.

Reviewed by Cursor Bugbot for commit 6e47d4b. Bugbot is set up for automated code reviews on this repo. Configure here.

@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-starknet_proof_verifier_add_v0.14.3_regression_case_for_proof_version_v1_fixture branch from d58cb65 to 6ac567b Compare May 10, 2026 17:01
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-starknet_api_starknet_proof_verifier_write_proof_version_v1_in_try_into_proof_facts branch from 26be1cf to 331d1e2 Compare May 10, 2026 17:01
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-starknet_api_starknet_proof_verifier_write_proof_version_v1_in_try_into_proof_facts branch from 331d1e2 to bd5effd Compare May 11, 2026 06:34
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-starknet_proof_verifier_add_v0.14.3_regression_case_for_proof_version_v1_fixture branch from 6ac567b to 963202d Compare May 11, 2026 06:34
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-starknet_api_starknet_proof_verifier_write_proof_version_v1_in_try_into_proof_facts branch from bd5effd to f8d1581 Compare May 11, 2026 07:23
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-starknet_proof_verifier_add_v0.14.3_regression_case_for_proof_version_v1_fixture branch from 963202d to 1a88611 Compare May 11, 2026 07:23
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-starknet_api_starknet_proof_verifier_write_proof_version_v1_in_try_into_proof_facts branch from f8d1581 to f5f61b8 Compare May 11, 2026 07:30
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-starknet_proof_verifier_add_v0.14.3_regression_case_for_proof_version_v1_fixture branch 2 times, most recently from ef43d9f to 67dfc82 Compare May 11, 2026 07:32
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-starknet_api_starknet_proof_verifier_write_proof_version_v1_in_try_into_proof_facts branch 2 times, most recently from 03c92c6 to b9bf614 Compare May 11, 2026 07:33
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-starknet_proof_verifier_add_v0.14.3_regression_case_for_proof_version_v1_fixture branch 2 times, most recently from 430f38c to c5a9d7f Compare May 11, 2026 07:55
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-starknet_api_starknet_proof_verifier_write_proof_version_v1_in_try_into_proof_facts branch 2 times, most recently from 23c4d2f to 872e8c6 Compare May 11, 2026 11:35
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-starknet_proof_verifier_add_v0.14.3_regression_case_for_proof_version_v1_fixture branch 2 times, most recently from 42bbbd4 to c5110f2 Compare May 11, 2026 11:49
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-starknet_api_starknet_proof_verifier_write_proof_version_v1_in_try_into_proof_facts branch from 872e8c6 to 51df181 Compare May 11, 2026 11:49
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-starknet_api_starknet_proof_verifier_write_proof_version_v1_in_try_into_proof_facts branch from 51df181 to f2620df Compare May 11, 2026 12:03
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-starknet_proof_verifier_add_v0.14.3_regression_case_for_proof_version_v1_fixture branch from c5110f2 to 6e47d4b Compare May 11, 2026 12:03
Copy link
Copy Markdown
Contributor

@AvivYossef-starkware AvivYossef-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@AvivYossef-starkware reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Yoni-Starkware).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants