Skip to content

blockifier,starknet_os: expect the blake constants in tests and check consistency#14035

Open
dorimedini-starkware wants to merge 1 commit into
05-15-starknet_os_recompute_and_assert_the_blake_constantsfrom
05-16-blockifier_starknet_os_expect_the_blake_constants_in_tests_and_check_consistency
Open

blockifier,starknet_os: expect the blake constants in tests and check consistency#14035
dorimedini-starkware wants to merge 1 commit into
05-15-starknet_os_recompute_and_assert_the_blake_constantsfrom
05-16-blockifier_starknet_os_expect_the_blake_constants_in_tests_and_check_consistency

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 16, 2026

@cursor
Copy link
Copy Markdown

cursor Bot commented May 16, 2026

PR Summary

Low Risk
Low risk: changes are limited to test-only validation of Blake hash estimation constants plus an optional expect-test dependency gated behind the testing feature.

Overview
Adds an expected module (gated behind test/testing) that centralizes expect-test snapshots for the CASM V2 (Blake) hash step-estimation constants, keeping production constants unchanged.

Updates Blockifier and Starknet OS tests to assert against these expect values and adds a new test that verifies the production constants match the expected snapshots, with expect-test wired in as an optional dependency under the testing feature.

Reviewed by Cursor Bugbot for commit 4cdda7f. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 57722b6. Configure here.

Comment thread crates/blockifier/src/execution/casm_hash_estimation_test.rs Outdated
@dorimedini-starkware dorimedini-starkware force-pushed the 05-16-blockifier_starknet_os_expect_the_blake_constants_in_tests_and_check_consistency branch from 57722b6 to c2492f9 Compare May 16, 2026 10:23
Copy link
Copy Markdown
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware resolved 2 discussions.
Reviewable status: 0 of 4 files reviewed, all discussions resolved (waiting on AvivYossef-starkware and Yoni-Starkware).

@dorimedini-starkware dorimedini-starkware force-pushed the 05-16-blockifier_starknet_os_expect_the_blake_constants_in_tests_and_check_consistency branch from c2492f9 to 4cdda7f Compare May 16, 2026 12:34
@dorimedini-starkware dorimedini-starkware force-pushed the 05-15-starknet_os_recompute_and_assert_the_blake_constants branch from 30206ec to 139758c Compare May 16, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants