starknet_os: use expect! to assert the blake constants for easy fixing

[dorimedini-starkware]

No description provided.

[dorimedini-starkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• starknet_os: use expect! to assert the blake constants for easy fixing #14033 👈 (View in Graphite)
• starknet_os: recompute and assert the blake constants #14032 : 1 other dependent PR (#14035 )
• blockifier: fix blake estimation offset by fixing constants #14034
• starknet_os: move blake constants to struct scope #14031
• starknet_os: extract cairo blake run to function #14030
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[reviewable-StarkWare]

This change is 

[github-actions]

Artifacts upload workflows:

• Started at 2026-05-15T15:35:36Z
• Started at 2026-05-15T15:42:14Z
• Started at 2026-05-15T16:53:11Z
• Started at 2026-05-16T09:40:40Z
• Started at 2026-05-16T09:43:14Z

[cursor]

PR Summary

Low Risk
Low risk: this mainly refactors how empirical Blake2s step constants are stored and asserted, without changing the underlying estimation logic or constant values.

Overview
Switches the Blake2s CASM hash step “constants” in blockifier::casm_hash_estimation from hardcoded usize values to expect-test-backed expectations, exposed as lazily-parsed LazyLock<usize> statics.

Updates unit tests in both blockifier and starknet_os to assert against the expect! snapshots (supporting UPDATE_EXPECT=1 workflows) and adjusts Cargo.toml so expect-test is a normal dependency (since the expectations are used in non-test code).

^{Reviewed by Cursor Bugbot for commit 1286e2e. Bugbot is set up for automated code reviews on this repo. Configure here.}

[cursor]

Test-only crate promoted to production dependency

Medium Severity

The expect-test crate — a snapshot testing library — is moved from [dev-dependencies] to [dependencies], making it a production dependency. The Expect type and expect! macro embed source file paths, line numbers, and column numbers, and are designed exclusively for test assertions with UPDATE_EXPECT=1 auto-fixing. The _EXPECT constants are only consumed by LazyLock parsers and test assertions — they serve no production purpose. This also downgrades six compile-time const usize values to runtime-parsed LazyLock<usize> statics, introducing a panic path (.parse().expect(...)) that previously could not exist.

Additional Locations (1)

• crates/blockifier/src/execution/casm_hash_estimation.rs#L243-L270

 

^{Reviewed by Cursor Bugbot for commit a3359be. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 1286e2e. Configure here.}

[cursor]

Compile-time constants replaced with runtime-parsed lazy statics

Medium Severity

Six constants that were previously const usize (e.g., const STEPS_EMPTY_INPUT: usize = 169) are now LazyLock<usize> statics that parse strings at runtime via .data.parse(). This converts compile-time-checked values into runtime-initialized values that can panic on first access, adds lock overhead on every dereference, and relies on #[doc(hidden)] internals of expect-test. The expect! pattern is intended for test assertions, not for defining production constants.

 

^{Reviewed by Cursor Bugbot for commit 1286e2e. Configure here.}