Skip to content

starknet_os: extract cairo blake run to function#14030

Open
dorimedini-starkware wants to merge 1 commit into
mainfrom
05-15-starknet_os_extract_cairo_blake_run_to_function
Open

starknet_os: extract cairo blake run to function#14030
dorimedini-starkware wants to merge 1 commit into
mainfrom
05-15-starknet_os_extract_cairo_blake_run_to_function

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 15, 2026

@cursor
Copy link
Copy Markdown

cursor Bot commented May 15, 2026

PR Summary

Low Risk
Low risk refactor limited to test code, mainly reorganizing how the Cairo entrypoint is invoked and how resources are asserted.

Overview
Refactors the blake2s_test Cairo-vs-Rust comparison by extracting the Cairo0 call into a reusable helper cairo_encode_felt252_data_and_calc_blake_hash that returns both the hash result and filtered execution resources.

The test now uses this helper, simplifies error handling (panic on failure), and keeps the existing assertions for hash equality and resource-estimate equality.

Reviewed by Cursor Bugbot for commit 4e1a7c7. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on AvivYossef-starkware and Yoni-Starkware).


a discussion (no related file):
no logic changes - just extracted the function that runs the entrypoint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants