Skip to content

blockifier: fix blake estimation offset by fixing constants#14034

Open
dorimedini-starkware wants to merge 1 commit into
05-15-starknet_os_move_blake_constants_to_struct_scopefrom
05-16-blockifier_fix_blake_estimation_offset_by_fixing_constants
Open

blockifier: fix blake estimation offset by fixing constants#14034
dorimedini-starkware wants to merge 1 commit into
05-15-starknet_os_move_blake_constants_to_struct_scopefrom
05-16-blockifier_fix_blake_estimation_offset_by_fixing_constants

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 16, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@dorimedini-starkware dorimedini-starkware self-assigned this May 16, 2026
@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review May 16, 2026 09:41
@cursor
Copy link
Copy Markdown

cursor Bot commented May 16, 2026

PR Summary

Medium Risk
Tweaks empirical VM-step constants that feed CASM hash/gas estimation, which can change transaction weight and fee-related calculations; errors would skew block packing and resource accounting.

Overview
Adjusts Blake2s CASM-hash resource estimation by decrementing the empirically-derived step constants used for empty input and message overhead in CasmV2HashResourceEstimate.

Updates OS and blockifier tests to match the corrected estimate: removes the prior one-step manual offset in blake2s_test.rs and refreshes expected migration gas numbers in bouncer_test.rs.

Reviewed by Cursor Bugbot for commit ba51f08. Bugbot is set up for automated code reviews on this repo. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants