Skip to content

285 282 fix tutorials table of contents fix input aligner type hint#290

Merged
ahcorde merged 2 commits into
ros2:rollingfrom
EsipovPA:285_282_fix_tutorials_table_of_contents_fix_input_aligner_type_hint
May 5, 2026
Merged

285 282 fix tutorials table of contents fix input aligner type hint#290
ahcorde merged 2 commits into
ros2:rollingfrom
EsipovPA:285_282_fix_tutorials_table_of_contents_fix_input_aligner_type_hint

Conversation

@EsipovPA
Copy link
Copy Markdown
Contributor

@EsipovPA EsipovPA commented May 4, 2026

Description

Fix tutorials table of contents bug.
Add valid type hint for callback in InputAligner

I;d propose to keep both commits and not to squash them, but I do not insist.

Fixes #285
Relates to #282

Is this user-facing behavior change?

Did you use Generative AI?

No, I did not.

Additional Information

@dvorak0 FYI. The second commit.

EsipovPA added 2 commits May 5, 2026 01:08
@EsipovPA
(ros2#285) Tutorials/Delta-Filter-Python: Fix tutorials table of cont…
4cf5c20 
…ents.

Signed-off-by: EsipovPA <esipov.p@mail.ru>
@EsipovPA
(ros2#282) SimpleFilter/InputAligner: Fix callback type hint
aec6b09 
Signed-off-by: EsipovPA <esipov.p@mail.ru>
This was referenced May 4, 2026
Merged
Closed
@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented May 5, 2026 •
edited
Loading

Pulls: #290
Gist: https://gist.githubusercontent.com/ahcorde/6b8f9de069ea1fc444064f586e9ea54a/raw/1cab45ed2fb413db8b3ae7c54d851c42963bf084/ros2.repos
BUILD args: --packages-above-and-dependencies message_filters
TEST args: --packages-above message_filters
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19139

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit 5a77cf8 into ros2:rolling May 5, 2026
2 checks passed
ahcorde pushed a commit that referenced this pull request May 5, 2026
@EsipovPA @ahcorde
285 282 fix tutorials table of contents fix input aligner type hint (#…
5ad5e0d 
…290)

Signed-off-by: EsipovPA <esipov.p@mail.ru>
@EsipovPA
Copy link
Copy Markdown
Contributor Author

EsipovPA commented May 21, 2026

Hello @ahcorde !

Is it possible to backport this PR to humble, jazzy and kilted? To fix the tutorials section and to add correct typings to the InputAligner and SimpleFilter there as well. It seems that after merging these three backport PRs

  1. feat(python): add python implementation of InputAligner (backport #283) #287
  2. feat(python): add python implementation of InputAligner (backport #283) #288
  3. feat(python): add python implementation of InputAligner (backport #283) #289

this one becomes backportable as well.

I think I can do it by hand, but it seems it will be more correct to create a backport commits. If it makes more sense, I'll do it by hand. Not a problem for me.

Sorry for the trouble :)

@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented May 21, 2026

https://github.com/Mergifyio backport lyrical kilted jazzy humble

@mergify
Copy link
Copy Markdown

mergify Bot commented May 21, 2026 •
edited
Loading

backport lyrical kilted jazzy humble

✅ Backports have been created

Details
  • Backport to branch lyrical completed

No pull request needed: No commits between lyrical and mergify/bp/lyrical/pr-290

This was referenced May 21, 2026
Merged
Merged
Merged
ahcorde pushed a commit that referenced this pull request May 21, 2026
@mergify @EsipovPA
285 282 fix tutorials table of contents fix input aligner type hint (#…
8ea38ec 
…290) (#298)

(cherry picked from commit 5a77cf8)

Signed-off-by: EsipovPA <esipov.p@mail.ru>
Co-authored-by: Pavel Esipov <38457822+EsipovPA@users.noreply.github.com>
ahcorde pushed a commit that referenced this pull request May 22, 2026
@mergify @EsipovPA
fix tutorials table of contents fix input aligner type hint (backport #…
cc80fe7 
…290) (#299)

(cherry picked from commit 5a77cf8)

Signed-off-by: EsipovPA <esipov.p@mail.ru>
Co-authored-by: Pavel Esipov <38457822+EsipovPA@users.noreply.github.com>
ahcorde pushed a commit that referenced this pull request May 25, 2026
@mergify @EsipovPA
fix tutorials table of contents fix input aligner type hint (backport #…
3e5bd5d 
…290) (#300)

(cherry picked from commit 5a77cf8)
Signed-off-by: EsipovPA <esipov.p@mail.ru>
Co-authored-by: Pavel Esipov <38457822+EsipovPA@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Issue with tutorials table of contents

2 participants

@EsipovPA @ahcorde