Skip to content

fix tutorials table of contents fix input aligner type hint (backport #290)#300

Open
mergify[bot] wants to merge 3 commits into
humblefrom
mergify/bp/humble/pr-290
Open

fix tutorials table of contents fix input aligner type hint (backport #290)#300
mergify[bot] wants to merge 3 commits into
humblefrom
mergify/bp/humble/pr-290

Conversation

@mergify
Copy link
Copy Markdown

@mergify mergify Bot commented May 21, 2026

Description

Fix tutorials table of contents bug.
Add valid type hint for callback in InputAligner

I;d propose to keep both commits and not to squash them, but I do not insist.

Fixes #285
Relates to #282

Is this user-facing behavior change?

Did you use Generative AI?

No, I did not.

Additional Information

@dvorak0 FYI. The second commit.

This is an automatic backport of pull request #290 done by [Mergify](https://mergify.com).

@EsipovPA @mergify
285 282 fix tutorials table of contents fix input aligner type hint (#…
cecd5b0 
…290)

Signed-off-by: EsipovPA <esipov.p@mail.ru>
(cherry picked from commit 5a77cf8)
@mergify mergify Bot mentioned this pull request May 21, 2026
Merged
@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented May 21, 2026

Pulls: #300
Gist: https://gist.githubusercontent.com/ahcorde/56d2bbe3928c3e3f16c5270140cb744c/raw/6de33de6ba0fac0fb3a1a06a7185abb5e04fa081/ros2.repos
BUILD args: --packages-above-and-dependencies message_filters
TEST args: --packages-above message_filters
ROS Distro: humble
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19340

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde changed the title 285 282 fix tutorials table of contents fix input aligner type hint (backport #290) fix tutorials table of contents fix input aligner type hint (backport #290) May 21, 2026
@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented May 21, 2026

@EsipovPA can you take a look to the test errors?

@EsipovPA
Copy link
Copy Markdown
Contributor

EsipovPA commented May 21, 2026

Hello @ahcorde!

I think this should do the trick for humble: #302

@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented May 21, 2026

Pulls: #300
Gist: https://gist.githubusercontent.com/ahcorde/d4b0349bf3f38cbb91ed3f1a5aa7b3a5/raw/6de33de6ba0fac0fb3a1a06a7185abb5e04fa081/ros2.repos
BUILD args: --packages-above-and-dependencies message_filters
TEST args: --packages-above message_filters
ROS Distro: humble
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19348

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@christophebedard christophebedard assigned ahcorde and unassigned EsipovPA May 21, 2026
@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented May 22, 2026

errors are still there @EsipovPA

@EsipovPA
Copy link
Copy Markdown
Contributor

EsipovPA commented May 22, 2026

Thank you @ahcorde.

Yes, I've noticed this. Just had no time to come up with a good enough solution yesterday evening. I'll try to fix it today. Seems like a simple enough issue. If no other issues are going to pop up later 🤷

Think I need a number of images for debugging with all 4 supported releases, but that'll take some time to build. Looks like a story for another time for me 🤷 .

@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented May 22, 2026

@EsipovPA Thank you very much for your dedication. Much appreciate it

@EsipovPA
Copy link
Copy Markdown
Contributor

EsipovPA commented May 22, 2026

If I am not mistaken, this should do the trick with the Concatenate: #303 🤞

@EsipovPA
(#285, #282): humble: Replace ellypsys with ParamSpec in callback typ…
4da7ccd 
…e hints in simple_filter.py and in input_aligner.py (#303)

Signed-off-by: EsipovPA <esipov.p@mail.ru>
@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented May 22, 2026

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

Assignees

@ahcorde ahcorde

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ahcorde @EsipovPA