Skip to content

starknet_committer: compute and store accessed keys digest#13993

Open
ArielElp wants to merge 1 commit into
ariel/get_leaf_indicies_utilityfrom
ariel/accessed_keys_digest
Open

starknet_committer: compute and store accessed keys digest#13993
ArielElp wants to merge 1 commit into
ariel/get_leaf_indicies_utilityfrom
ariel/accessed_keys_digest

Conversation

@ArielElp
Copy link
Copy Markdown
Contributor

@ArielElp ArielElp commented May 7, 2026

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Contributor Author

ArielElp commented May 7, 2026

@ArielElp ArielElp force-pushed the ariel/get_leaf_indicies_utility branch from b0885bd to b925279 Compare May 14, 2026 08:43
@ArielElp ArielElp force-pushed the ariel/accessed_keys_digest branch from 19be0db to 7768006 Compare May 14, 2026 08:43
@ArielElp ArielElp requested a review from yoavGrs May 14, 2026 09:16
@ArielElp ArielElp marked this pull request as ready for review May 14, 2026 09:16
@cursor
Copy link
Copy Markdown

cursor Bot commented May 14, 2026

PR Summary

Medium Risk
Adds new deterministic hashing logic (sorting + bincode wire format) to fingerprint accessed read keys, which could affect any downstream replay/verification if the canonicalization format changes. Impact is limited by being gated behind the os_input feature flag.

Overview
Adds a new os_input feature (and optional bincode/blake2/digest deps) to enable computing a deterministic fingerprint of accessed read keys.

Introduces accessed_keys_digest in serde_db_utils.rs, which canonicalizes accessed class hashes, contract addresses, and per-contract storage keys via sorting, serializes the canonical structure with bincode, and hashes it with BLAKE2s-256 to produce a [u8; 32] digest.

Reviewed by Cursor Bugbot for commit 7768006. Bugbot is set up for automated code reviews on this repo. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants