Skip to content

starknet_committer: abstract fetch_all_patricia_paths#13991

Open
ArielElp wants to merge 1 commit into
graphite-base/13991from
ariel/abstract_fetch_all_patricia_paths
Open

starknet_committer: abstract fetch_all_patricia_paths#13991
ArielElp wants to merge 1 commit into
graphite-base/13991from
ariel/abstract_fetch_all_patricia_paths

Conversation

@ArielElp
Copy link
Copy Markdown
Contributor

@ArielElp ArielElp commented May 7, 2026

No description provided.

Copy link
Copy Markdown
Contributor Author

ArielElp commented May 7, 2026

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@ArielElp ArielElp force-pushed the ariel/add_two_layer_storage branch from 2de219b to d746081 Compare May 14, 2026 08:43
@ArielElp ArielElp force-pushed the ariel/abstract_fetch_all_patricia_paths branch from 1e786d7 to 526b5f0 Compare May 14, 2026 08:43
@ArielElp ArielElp requested a review from yoavGrs May 14, 2026 09:16
@ArielElp ArielElp marked this pull request as ready for review May 14, 2026 09:16
@cursor
Copy link
Copy Markdown

cursor Bot commented May 14, 2026

PR Summary

Medium Risk
Medium risk because it changes core proof-generation traversal to be generic over DbLayout and adds leaf type conversions, which could cause subtle type/serialization mismatches if a new layout implementation is incorrect.

Overview
Generalizes fetch_all_patricia_paths to be pub and generic over a DbLayout, wiring fetch_patricia_paths calls through layout-provided leaf and node types instead of the fixed FactsNodeLayout.

Updates contracts-trie leaf handling to convert from Layout::ContractStateDbLeaf into ContractState (including when extracting storage_root_hash), and explicitly constrains fetch_previous_and_new_patricia_paths to the facts layout by instantiating fetch_all_patricia_paths::<FactsNodeLayout>.

Reviewed by Cursor Bugbot for commit 526b5f0. Bugbot is set up for automated code reviews on this repo. Configure here.

@ArielElp ArielElp changed the base branch from ariel/add_two_layer_storage to graphite-base/13991 May 14, 2026 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants