starknet_committer: move fetch_patricia_paths tests#13960
Conversation
621ebfb to
621d40d
Compare
414244d to
22604c1
Compare
PR SummaryLow Risk Overview Fixes the Reviewed by Cursor Bugbot for commit 3f8b451. Bugbot is set up for automated code reviews on this repo. Configure here. |
yoavGrs
left a comment
There was a problem hiding this comment.
@yoavGrs partially reviewed 2 files and made 2 comments.
Reviewable status: 2 of 3 files reviewed, 2 unresolved discussions (waiting on ArielElp).
crates/starknet_committer/src/db.rs line 13 at r1 (raw file):
#[cfg(test)] mod fetch_patricia_paths_tests;
Define it in trie_traversal.rs.
Code quote:
#[cfg(test)]
mod fetch_patricia_paths_tests;crates/starknet_committer/src/db/trie_traversal.rs line 57 at r1 (raw file):
#[cfg(test)] #[path = "facts_db/traversal_test.rs"]
According to code quality, it should stay here.
Suggestion:
#[path = "traversal_test.rs"]621d40d to
6d471bd
Compare
22604c1 to
4c3049b
Compare
6d471bd to
3f8b451
Compare
ArielElp
left a comment
There was a problem hiding this comment.
@ArielElp partially reviewed 2 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on yoavGrs).
crates/starknet_committer/src/db.rs line 13 at r1 (raw file):
Previously, yoavGrs wrote…
Define it in
trie_traversal.rs.
Done.
crates/starknet_committer/src/db/trie_traversal.rs line 57 at r1 (raw file):
Previously, yoavGrs wrote…
According to code quality, it should stay here.
You mean under facts_db, it's weird now that it's generic right?
In any case, I moved the definition to trie_traversal.
yoavGrs
left a comment
There was a problem hiding this comment.
@yoavGrs reviewed 2 files and all commit messages, and resolved 2 discussions.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on ArielElp).

No description provided.