Expose current popover target in PopoverContainer#6743
Draft
JerryK73 wants to merge 1 commit into
Draft
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| private readonly Container dismissOnMouseDownContainer; | ||
|
|
||
| private IHasPopover? target; | ||
| public IHasPopover? CurrentTarget => target; |
Collaborator
|
You have authored contributions to other projects with self-disclosed LLM usage (example). LLM usage is not allowed in this repository. Please disclose whether LLMs have been used to author this contribution in any capacity. |
Author
|
Hi @bdach thanks for the comment, I did not use LLMs while developing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr was created to assist in fixing menu toggling using f3 (Issue #36331 on the main branch). Here is the pr for that as well.
This pr adds a public CurrentTarget property to PopoverContainer that exposes which IHasPopover source currently has a visible popover. This is needed to allow callers to determine whether a popover is already open before deciding to show or hide it.