Skip to content

Expose current popover target in PopoverContainer #6743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
JerryK73 wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −0
Draft

Expose current popover target in PopoverContainer #6743

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions osu.Framework/Graphics/Cursor/PopoverContainer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
private readonly Container dismissOnMouseDownContainer;

private IHasPopover? target;
public IHasPopover? CurrentTarget => target;

Check warning

Code scanning / InspectCode

Convert property into auto-property with private setter Warning

Convert into auto-property with private setter
Copy link
Copy Markdown
Member

@peppy peppy May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JerryK73 do you intend to fix this?

private Popover? currentPopover;

protected override Container<Drawable> Content => content;
Expand Down
Loading