Fix options menu not toggling off when pressing f3 again#37648
Draft
JerryK73 wants to merge 1 commit into
Draft
Conversation
Author
|
Note: The tests are failing because this depends on the changes from the framework pull request. |
Collaborator
|
You have authored contributions to other projects with self-disclosed LLM usage (example). LLM usage is not allowed in this repository. Please disclose whether LLMs have been used to author this contribution in any capacity. |
Author
|
Hi @bdach thanks for the comment, I did not use LLMs while developing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously pressing f3 again when the options menu was open would just open it again. This code changes the Action from always showing the popover to closing it if it is already open.
As noted in the original issue, framework changes were also required for this to work. You can find the separate pr here.
Was unsure if tests were necessary for a fix with minimal changes like this, please let me know if you would like me to add some!
Fixes issue #36331