staging: Remove unused internal banmanager.#3626
Merged
davecgh merged 1 commit intodecred:masterfrom Mar 3, 2026
Merged
Conversation
This was referenced Feb 28, 2026
jrick
approved these changes
Mar 3, 2026
With the introduction of version 2 addresses, upcoming work will be overhauling a lot of networking code. Those changes will necessarily conflict heavily with the vast majority of code that deals with addresses in any way. That includes the internal banmanager staging code which is, unfortunately, based heavily around string addresses. Due to that, and a variety of other design issues, it has never been integrated. In light of the aforementioned, rather than writing a bunch of temporary shim code that ultimately would just end up being removed anyway, this opts to remove the unused code now. Centralized ban handling via something similar is ideal and something that should eventually happen and this code will be in commit history when the time comes to resurrect it and give it the overhaul it needs.
davecgh
force-pushed
the
scrap_internal_banmgr
branch
from
9f85733 to
e946f2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the introduction of version 2 addresses, upcoming work will be overhauling a lot of networking code. Those changes will necessarily conflict heavily with the vast majority of code that deals with addresses in any way.
That includes the internal banmanager staging code which is, unfortunately, based heavily around string addresses. Due to that, and a variety of other design issues, it has never been integrated.
In light of the aforementioned, rather than writing a bunch of temporary shim code that ultimately would just end up being removed anyway, this opts to remove the unused code now.
Centralized ban handling via something similar is ideal and something that should eventually happen and this code will be in commit history when the time comes to resurrect it and give it the overhaul it needs.