peer: Remove wire net address references.#3631
Merged
davecgh merged 1 commit intodecred:masterfrom Mar 3, 2026
Merged
Conversation
davecgh
force-pushed
the
peer_remove_wire_netaddr_refs
branch
4 times, most recently
from
38f204e to
e40f718
Compare
jrick
approved these changes
Mar 3, 2026
Now that the rest of the code has been converted to no longer make use of the net address associated with the peer, the only remaining use is for the initial handshake. Given that the handshake is only a one time event that happens during the initialization phase, there is no longer a reason to keep a reference around. With that in mind, this moves the logic that creates the version 1 network address required during the handshake to the handshake path itself and removes all other references.
davecgh
force-pushed
the
peer_remove_wire_netaddr_refs
branch
from
e40f718 to
5cd942a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This requires #3626, #3629, and #3630.Now that the rest of the code has been converted to no longer make use of the net address associated with the peer, the only remaining use is for the initial handshake.
Given that the handshake is only a one time event that happens during the initialization phase, there is no longer a reason to keep a reference around.
With that in mind, this moves the logic that creates the version 1 network address required during the handshake to the handshake path itself and removes all other references.