peer: Convert address strings to net.Addr.#3630
Merged
davecgh merged 2 commits intodecred:masterfrom Mar 3, 2026
Merged
Conversation
davecgh
force-pushed
the
peer_use_stdlib_net_addr
branch
from
b978ee3 to
ff82b6a
Compare
davecgh
force-pushed
the
peer_use_stdlib_net_addr
branch
3 times, most recently
from
b401252 to
5089236
Compare
This does some minor cleanup on the peer tests to use more recent formatting and consistently use remote addresses.
This modifies NewOutboundPeer to accept a net.Addr instead of a string so it is consistent with the inbound constructor and more flexible. Since both constructors now accept a net.Addr, it also updates the internal field the tracks the remote address to store the net.Addr instead of a string.
davecgh
force-pushed
the
peer_use_stdlib_net_addr
branch
from
5089236 to
7fa4800
Compare
jrick
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This requires #3626 and #3629.This modifies
NewOutboundPeerto accept anet.Addrinstead of a string so it is consistent with the inbound constructor and more flexible.Since both constructors now accept a
net.Addr, it also updates the internal field the tracks the remote address to store thenet.Addrinstead of a string.