Draft
Conversation
texhnolyze
force-pushed
the
feature/hsl-gamecontroller-migration
branch
2 times, most recently
from
f8147b9 to
8404c35
Compare
to `game_controller_hsl` as the new [Gamecontroller] only expectes an `(x, y)` coordinate. [Gamecontroller]: https://github.com/RoboCup-HumanoidSoccerLeague/GameController/
…in bodybehaviour too
texhnolyze
force-pushed
the
feature/hsl-gamecontroller-migration
branch
from
8404c35 to
785e5f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I've tried to extract, clean up and condense the game controller changes...
And there still is some stuff I'd like to improve ideally, before merging (i.e. remove TODOs, don't make HCM depend on behavior for game controller, move publishing of return data to central place and maybe create a full custom Message for the whole return object to the gamecontroller in https://github.com/bit-bots/game_controller_hsl reducing the number of pub/subs one needs).
Proposed changes
Related issues
Checklist
pixi run build