Skip to content

Editorial: Restructure update the image data step 15 #12372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
annevk merged 2 commits into from
Apr 15, 2026
+15 −6
Merged

Editorial: Restructure update the image data step 15 #12372

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
968e0eb
Editorial: Restructure `update the image data` step 15
jmdyck Apr 15, 2026
6029b20
fixup: Remove a "then", insert a "then"
jmdyck Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions source
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32891,12 +32891,21 @@ was an English &lt;a href="/wiki/Music_hall">music hall&lt;/a> singer, ...</code
the <span>pending request</span>'s <span data-x="img-req-url">current URL</span>, then
return.</p></li>

<li><p>If <var>urlString</var> is the same as the <span>current request</span>'s <span
data-x="img-req-url">current URL</span> and the <span>current request</span>'s <span
data-x="img-req-state">state</span> is <span data-x="img-inc">partially available</span>, then
<span>abort the image request</span> for the <span>pending request</span>, <span>queue an element
task</span> on the <span>DOM manipulation task source</span> given the <code>img</code> element
to <span>restart the animation</span> if <i>restart animation</i> is set, and return.</p></li>
<li>
<p>If <var>urlString</var> is the same as the <span>current request</span>'s <span
data-x="img-req-url">current URL</span> and the <span>current request</span>'s <span
data-x="img-req-state">state</span> is <span data-x="img-inc">partially available</span>:</p>

<ol>
<li><p><span>Abort the image request</span> for the <span>pending request</span>.</p></li>

<li><p>If <i>restart animation</i> is set, then <span>queue an element task</span> on the
<span>DOM manipulation task source</span> given the <code>img</code> element to <span>restart
the animation</span>.</p></li>

<li><p>Return.</p></li>
</ol>
</li>

<li><p><span>Abort the image request</span> for the <span>pending request</span>.</p></li>

Copy link
Copy Markdown
Member

@annevk annevk Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to move this in front to deduplicate I think that'd be good. I looked at "Abort the image request" and it doesn't invalidate any state we care about here.

Copy link
Copy Markdown
Contributor Author

@jmdyck jmdyck Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! I added a commit for this, but you've already merged the PR. Ah well, NBD.

Copy link
Copy Markdown
Member

@annevk annevk Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh I’ll wait a bit longer next time. I assumed you were not comfortable with this change.

Expand Down
Loading