Editorial: Restructure update the image data step 15#12372
Editorial: Restructure update the image data step 15#12372annevk merged 2 commits intowhatwg:mainfrom
update the image data step 15#12372Conversation
|
An unrelated thing I noticed: whether the step 15 condition is true or not, the next thing that will happen is |
annevk
left a comment
annevk
left a comment
There was a problem hiding this comment.
Couple nits, but looks good to me overall.
| data-x="img-req-state">state</span> is <span data-x="img-inc">partially available</span>, | ||
| then:</p> |
There was a problem hiding this comment.
| data-x="img-req-state">state</span> is <span data-x="img-inc">partially available</span>, | |
| then:</p> | |
| data-x="img-req-state">state</span> is <span data-x="img-inc">partially available</span>:</p> |
| <ol> | ||
| <li><p><span>Abort the image request</span> for the <span>pending request</span>.</p></li> | ||
|
|
||
| <li><p>If <i>restart animation</i> is set, <span>queue an element task</span> on the <span>DOM |
There was a problem hiding this comment.
| <li><p>If <i>restart animation</i> is set, <span>queue an element task</span> on the <span>DOM | |
| <li><p>If <i>restart animation</i> is set, then <span>queue an element task</span> on the <span>DOM |
| </ol> | ||
| </li> | ||
|
|
||
| <li><p><span>Abort the image request</span> for the <span>pending request</span>.</p></li> |
There was a problem hiding this comment.
If you want to move this in front to deduplicate I think that'd be good. I looked at "Abort the image request" and it doesn't invalidate any state we care about here.
There was a problem hiding this comment.
Whoops! I added a commit for this, but you've already merged the PR. Ah well, NBD.
There was a problem hiding this comment.
Ooh I’ll wait a bit longer next time. I assumed you were not comfortable with this change.
|
Thank you! |
2 participants
Step 15 of the
update the image datacontains a postfix 'if' whose scope is ambiguous: does it start at the 'queue' or at the 'restart'? This PR adds structure to the step to make the scope clear (assuming it starts at 'queue')./images.html ( diff )