Skip to content

Adjustment to meet Vaadin 8.14.1's newer Jsoup dependency #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mpetris wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Adjustment to meet Vaadin 8.14.1's newer Jsoup dependency #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c5ae391
bugfix: in the case of a LeafNode calling childNodes throws an Except…
mpetris Dec 14, 2018
948fce5
access to index 2 fails for elements with no children and no attribut…
mpetris Dec 14, 2018
bc83b75
added tests to check changes for parsing DOM leafs without attributes…
mpetris Dec 19, 2018
8c0f9ee
Update elements-demo/pom.xml
Legioth Dec 21, 2018
cfb2df4
Update elements/pom.xml
Legioth Dec 21, 2018
99dd032
Update elements/src/main/java/org/vaadin/elements/impl/Context.java
Legioth Dec 21, 2018
f7d8d53
Update elements/src/test/java/org/vaadin/elements/RootTest.java
Legioth Dec 21, 2018
0587fd9
Merge remote-tracking branch 'vaadin/master'
mpetris May 19, 2022
f6dcd15
adjusted construction of jsoup TextNode to the newer version of jsoup…
mpetris May 19, 2022
9191c6a
Merge branch 'master' of github.com:mpetris/serverside-elements
mpetris May 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions elements/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@
<groupId>org.vaadin</groupId>
<artifactId>elements</artifactId>
<packaging>jar</packaging>
<version>0.2.1-SNAPSHOT</version>
<version>0.2.3-SNAPSHOT</version>
<name>Elements Add-on</name>

<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<vaadin.version>8.0.5</vaadin.version>
<vaadin.version>8.14.1</vaadin.version>
<vaadin.plugin.version>${vaadin.version}</vaadin.plugin.version>

<!-- ZIP Manifest fields -->
Expand Down
2 changes: 1 addition & 1 deletion elements/src/main/java/org/vaadin/elements/Elements.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,6 @@ private static String getElementTag(final Class<?> type,

public static TextNode createText(String text) {
return (TextNode) ElementReflectHelper
.wrap(new org.jsoup.nodes.TextNode(text, ""));
.wrap(new org.jsoup.nodes.TextNode(text));
}
}
4 changes: 2 additions & 2 deletions elements/src/main/java/org/vaadin/elements/impl/Context.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ public void wrapChildren(NodeImpl node) {

while (!queue.isEmpty()) {
Node soupChild = queue.poll();
// Only relevant for newer JSoup versions
if (soupChild.childNodeSize() > 0) {
// Only relevant for newer JSoup versions
if (soupChild.childNodeSize() > 0) {
queue.addAll(soupChild.childNodes());
}

Expand Down