Adjustment to meet Vaadin 8.14.1's newer Jsoup dependency#31
Open
mpetris wants to merge 10 commits intovaadin:masterfrom
Open
Adjustment to meet Vaadin 8.14.1's newer Jsoup dependency#31mpetris wants to merge 10 commits intovaadin:masterfrom
mpetris wants to merge 10 commits intovaadin:masterfrom
Conversation
…ion, therefore check childNodeSize first
…es because array size is 2 then conaining only tagname and element id therefore we check for length before trying access at idx 2
… and adding LeafNode work in order to test LeafNode an upgrade of the referenced vaadin version because of the newer jsoup dependency was necessary
Co-Authored-By: mpetris <marco.petris@web.de>
Co-Authored-By: mpetris <marco.petris@web.de>
Co-Authored-By: mpetris <marco.petris@web.de>
Co-Authored-By: mpetris <marco.petris@web.de>
… which requires one argument instead of two this enables compatibility with Vaadin Framework 8.14.1 which ships with the newer jsoup version (1.14.2)
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Jsoup's old TextNode constructor had two arguments and the second one was marked deprecated. The newer version of Jsoup 1.14.2 which ships with Vaadin 8.14.1 has only one argument with the deprecated one having been removed. This fix corrects the call to the construtor by passing just one argument in.
Type of change
Checklist
Additional for
Featuretype of change