Skip to content

Adjustment to meet Vaadin 8.14.1's newer Jsoup dependency#31

Open
mpetris wants to merge 10 commits intovaadin:masterfrom
mpetris:master
Open

Adjustment to meet Vaadin 8.14.1's newer Jsoup dependency#31
mpetris wants to merge 10 commits intovaadin:masterfrom
mpetris:master

Conversation

@mpetris
Copy link
Copy Markdown
Contributor

@mpetris mpetris commented May 19, 2022

Description

Jsoup's old TextNode constructor had two arguments and the second one was marked deprecated. The newer version of Jsoup 1.14.2 which ships with Vaadin 8.14.1 has only one argument with the deprecated one having been removed. This fix corrects the call to the construtor by passing just one argument in.

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

mpetris and others added 10 commits December 14, 2018 15:39
…es because array size is 2 then conaining only tagname and element id

therefore we check for length before trying access at idx 2
… and adding LeafNode work

in order to test LeafNode an upgrade of the referenced vaadin version because of the newer jsoup dependency was necessary
Co-Authored-By: mpetris <marco.petris@web.de>
Co-Authored-By: mpetris <marco.petris@web.de>
Co-Authored-By: mpetris <marco.petris@web.de>
Co-Authored-By: mpetris <marco.petris@web.de>
… which requires one argument instead of two

this enables compatibility with Vaadin Framework 8.14.1 which ships with the newer jsoup version (1.14.2)
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 19, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ mpetris
❌ Legioth
You have signed the CLA already but the status is still pending? Let us recheck it.

@mpetris mpetris changed the title Adjustment to meet Vaadin 8.1.14's newer Jsoup dependency Adjustment to meet Vaadin 8.14.1's newer Jsoup dependency May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants