Skip to content

954: Added Henry and Arsh to Reviewers #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Arshadul-Monir merged 1 commit into from
Apr 15, 2026
+1 −1
Merged

954: Added Henry and Arsh to Reviewers #900

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/approval.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
const ME = context.payload.pull_request.user.login;
const OWNER = 'tahminator';
const GUARDIANS_OF_THE_GALAXY = (() => {
let initialGuardians = ['angelayu0530'];
let initialGuardians = ['Arshadul-Monir', 'arklian'];
Comment thread
Arshadul-Monir marked this conversation as resolved.
Comment thread
Arshadul-Monir marked this conversation as resolved.
Copy link

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usernames are compared with strict, case-sensitive string equality (e.g., approved.includes(u) and u !== ME). Adding a mixed-case login here increases the chance the approvals check mis-detects an approval if GitHub returns a different casing for user.login (logins are case-insensitive on GitHub, but strings here are not). Consider normalizing all logins to a consistent case (e.g., lowercasing ME, OWNER, r.user.login, and the GUARDIANS_OF_THE_GALAXY entries) before comparisons.

Copilot uses AI. Check for mistakes.

return initialGuardians;
})();
Expand Down
Loading