954: Added Henry and Arsh to Reviewers#900
Conversation
|
/deploy |
Available PR Commands
See: https://github.com/tahminator/codebloom/wiki/CI-Commands |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Title954: Added Henry and Arsh to Reviewers PR TypeEnhancement Description
|
| Relevant files | |||
|---|---|---|---|
| Configuration changes |
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
Title954: Added Henry and Arsh to Reviewers PR TypeEnhancement Description
|
| Relevant files | |||
|---|---|---|---|
| Configuration changes |
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
|
/deploy |
There was a problem hiding this comment.
Pull request overview
Updates the GitHub Actions approvals enforcement workflow to reflect a new set of “Guardians of the Galaxy” reviewers.
Changes:
- Replaced the previous guardian (
angelayu0530) withArshadul-Monirandarklianin the approvals check workflow.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const OWNER = 'tahminator'; | ||
| const GUARDIANS_OF_THE_GALAXY = (() => { | ||
| let initialGuardians = ['angelayu0530']; | ||
| let initialGuardians = ['Arshadul-Monir', 'arklian']; |
There was a problem hiding this comment.
Usernames are compared with strict, case-sensitive string equality (e.g., approved.includes(u) and u !== ME). Adding a mixed-case login here increases the chance the approvals check mis-detects an approval if GitHub returns a different casing for user.login (logins are case-insensitive on GitHub, but strings here are not). Consider normalizing all logins to a consistent case (e.g., lowercasing ME, OWNER, r.user.login, and the GUARDIANS_OF_THE_GALAXY entries) before comparisons.
954
Description of changes
Added Arsh and Henry to guardians of galaxy. Removed Angela
Checklist before review
Screenshots
Dev
Staging