Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/blockifier/src/execution/execution_utils.rs
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,7 @@ pub fn execute_deployment(

context.revert_infos.0.push(EntryPointRevertInfo::new(
deployed_contract_address,
current_class_hash,
ClassHash::default(),
context.n_emitted_events,
context.n_sent_messages_to_l1,
));
Expand Down
4 changes: 4 additions & 0 deletions crates/blockifier/src/execution/syscalls/syscall_base.rs
Original file line number Diff line number Diff line change
Expand Up @@ -456,6 +456,10 @@ impl<'state> SyscallHandlerBase<'state> {
let reverted_call = &mut self.inner_calls.last_mut().unwrap();
let mut stack: Vec<&mut CallInfo> = vec![reverted_call];
while let Some(call_info) = stack.pop() {
// TODO(Dori): consider not clearing at all, and simply rely on the failed flag to
// compute the correct events and l2_to_l1_messages in a subtree. Or, we can simply
// clear these when the tx execution is finalized, once, and not per failure point.
// Or, just document this properly...
call_info.execution.events.clear();
call_info.execution.l2_to_l1_messages.clear();
// Add inner calls that did not fail to the stack.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ impl<U: UpdatableState> ExecutableTransaction<U> for L1HandlerTransaction {
match fee_check_report {
Ok(()) => {
// Post-execution check passed, commit the execution.
// TODO(Dori): why commit here instead of first checking the paid fee?
execution_state.commit();
// TODO(Arni): Consider removing this check. It is covered by the starknet
// core contract.
Expand Down
Loading