Skip to content

chore: audit remarks#14004

Open
dorimedini-starkware wants to merge 1 commit into
mainfrom
dori-audit
Open

chore: audit remarks#14004
dorimedini-starkware wants to merge 1 commit into
mainfrom
dori-audit

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

Signed-off-by: Dori Medini <dori@starkware.co>
@dorimedini-starkware dorimedini-starkware self-assigned this May 7, 2026
@cursor
Copy link
Copy Markdown

cursor Bot commented May 7, 2026

PR Summary

Low Risk
Low risk: behavior change is minimal (a default class hash is now explicitly recorded), with the rest being comments/TODOs only.

Overview
Tightens revert bookkeeping during contract deployment by explicitly recording ClassHash::default() in EntryPointRevertInfo instead of reusing current_class_hash.

Adds audit TODOs documenting potential improvements/ambiguity around clearing events/L2→L1 messages on failed inner calls and the commit-vs-fee-check ordering in L1 handler execution.

Reviewed by Cursor Bugbot for commit d496818. Bugbot is set up for automated code reviews on this repo. Configure here.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

Artifacts upload workflows:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants