Add support to store passwords and tokens in the OS Keyring#5
Closed
notthatjesus wants to merge 10 commits intossp-data:mainfrom
Closed
Add support to store passwords and tokens in the OS Keyring#5notthatjesus wants to merge 10 commits intossp-data:mainfrom
notthatjesus wants to merge 10 commits intossp-data:mainfrom
Conversation
…ns within the OS keyring
…ge of new account passwords
…g one in file to the keyring
…lback to file storage
Contributor
Author
|
This PR includes as well the update to the benchmark adding support for oauth accounts (#4) because I branched from that one. |
Contributor
Author
|
Moving it back to draft to simplify the changes |
| Host: h, | ||
| Port: p, | ||
| User: acc.User, | ||
| Password: acc.Password, |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds support to use OS default keyring instead of storing the passwords and tokens in files. The implementation is done with backwards compatibility as well as adding a migration path to move current passwords to the keyring.
Changes
go-keyringas direct dependency