Conversation
Re-implementation of PR #5 onto current main. Differences vs the original PR: - Resolves the "keyring" sentinel inside config.Load() rather than at IMAP construction time. This fixes the [[senders]] gap: SMTP send paths and sender aliases that reference an account now see the resolved password automatically without needing their own keyring lookup. - OAuth2 token storage uses keyring with file fallback for headless/SSH. TokenSource keeps its existing func() (string, error) signature; no caller-side API changes. Foundations only — :set-password / :migrate-to-keyring cmdline commands and the password_prompt UI integration are intentionally deferred. Users on this branch must seed the keyring externally (e.g. secret-tool, kwallet, or a one-off Go helper) before launching neomd. Co-Authored-By: Jesus Rodriguez <jesus.rodriguez.estevez@gmail.com> Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| if err != nil { | ||
| return err | ||
| } | ||
| defer f.Close() |
Contributor
|
Thanks for picking this up @sspaeti !! Apologies I couldn't get back to this, glad that the previous PR helped. I'll run some testing on Mac and Omarchy later today. |
Member
Author
|
@notthatjesus No thank you! This is an amazing feature, and I could use most of it directly! I replaced my envs directly :) Please test with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on great insights from #5 I pulled relevant changes into the latest main branch, and left out the migration cmd as people can just update the config.toml.
I tested it and updated mine, seems to work fine. Thanks so much @notthatjesus. Let's see after that merge, if we need anything more, but I think, if you agree, we can close #5 afterward. Lets see, would be great if you can test yours again main too and latest version with this.