[Topology.Mapping] Refactor Hexa2TetraTopologicalMapping to improve readability and add unit tests#5981
Open
alxbilger wants to merge 7 commits intosofa-framework:masterfrom
Open
[Topology.Mapping] Refactor Hexa2TetraTopologicalMapping to improve readability and add unit tests#5981alxbilger wants to merge 7 commits intosofa-framework:masterfrom
alxbilger wants to merge 7 commits intosofa-framework:masterfrom
Conversation
…r as we already have a BaseMeshTopology
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #5947
This PR refactors the
Hexa2TetraTopologicalMappingto improve its readability and maintainability. It introduces static arrays for defining tetrahedron patterns and uses loops with these patterns for creating tetrahedra, replacing explicit individual calls. The commit also adds comprehensive unit tests to ensure the correct functionality of the mapping, including edge swapping logic and various grid configurations. These changes aim to make the code more robust and easier to understand.Here's a list of the main changes:
Refactoring of :
Hexa2TetraTopologicalMapping.cppThe code has been cleaned up by replacing explicit vertex swapping for X, Y, and Z edges with loops iterating oversofa::geometry::Hexahedron::xEdges,yEdges, andzEdges. The direct addition of tetrahedra has also been refactored to use predefined patterns, improving readability.Introduction of Test Cases: New unit tests have been added in
Hexa2TetraTopologicalMapping_test.cppto cover various aspects of the mapping, including:swappingparameter.Enhancements to :
Hexahedron.hStatic constant arrays (xEdges,yEdges,zEdges) have been added toHexahedron.hto define the edges along each axis, which are then used in the mapping logic.[with-all-tests]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if