Skip to content

NO-SNOW: Skip bind variable test with SQL simplifier disabled #4214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sfc-gh-joshi merged 1 commit into from
May 7, 2026
Merged

NO-SNOW: Skip bind variable test with SQL simplifier disabled #4214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions tests/integ/test_bind_variable.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,11 +483,23 @@ def proc_name(session):
IS_IN_STORED_PROC,
reason="SNOW-3454682: connector issue in stored procedures breaks this test",
)
@pytest.mark.skipif(
"config.getoption('disable_sql_simplifier', default=False)",
reason="Parameters are not properly propagated when the simplifier is disabled (see comment)",
)
class TestCallIdentifierBinding:
"""
SNOW-3061745: Bindings in CALL previously were not properly transferred through the expression tree.
These previously errored out when a chained operation after `session.sql` triggered a call to
`to_subqueryable`, which did not properly populate binding parameters.

This test fails in stored procedures due to a connector bug (SNOW-3454682).

This test also fails when the SQL simplifier is disabled. When it is enabled, query parameters are
propagated in `SnowflakePlan._analyze_attributes` through the parent `source_plan` field, but this
field is `None` for plans constructed from raw SQL when the simplifier is disabled. It is possible
to retrieve paramters by checking `self.queries[-1]`, but this approach is too brittle to be reliable,
as the final query in the list does not necessarily correspond to the query this plan represents.
"""

def test_call_collect(self, session, proc_name):
Expand Down
Loading