Skip to content

NO-SNOW: Skip bind variable test with SQL simplifier disabled#4214

Merged
sfc-gh-joshi merged 1 commit into
mainfrom
joshi/skip-bind-no-simplifier
May 7, 2026
Merged

NO-SNOW: Skip bind variable test with SQL simplifier disabled#4214
sfc-gh-joshi merged 1 commit into
mainfrom
joshi/skip-bind-no-simplifier

Conversation

@sfc-gh-joshi
Copy link
Copy Markdown
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-NNNNNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines
  3. Please describe how your code solves the related issue.

    test_bind_variable.py::TestCallIdentifierBinding fails with the SQL simplifier disabled due to architectural reasons. The only possible fixes are either too fragile or too involved to be worth the effort, so I've elected to skip the test when the simplifier is disabled.

@sfc-gh-joshi sfc-gh-joshi requested a review from a team as a code owner May 5, 2026 20:48
@sfc-gh-joshi sfc-gh-joshi changed the title add another skip condition NO-SNOW: Skip bind variable test with SQL simplifier disabled May 5, 2026
@sfc-gh-joshi sfc-gh-joshi added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label May 5, 2026
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.42%. Comparing base (2051e02) to head (d27fbad).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4214      +/-   ##
==========================================
- Coverage   95.42%   95.42%   -0.01%     
==========================================
  Files         171      171              
  Lines       43837    43876      +39     
  Branches     7513     7525      +12     
==========================================
+ Hits        41833    41869      +36     
- Misses       1225     1226       +1     
- Partials      779      781       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sfc-gh-joshi sfc-gh-joshi enabled auto-merge (squash) May 7, 2026 00:14
@sfc-gh-joshi sfc-gh-joshi merged commit 6a636b4 into main May 7, 2026
76 of 80 checks passed
@sfc-gh-joshi sfc-gh-joshi deleted the joshi/skip-bind-no-simplifier branch May 7, 2026 20:51
@github-actions github-actions Bot locked and limited conversation to collaborators May 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants