Skip to content

fix: Make template override arg work correctly #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
moehanabi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Make template override arg work correctly #522

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion specforge/data/template.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def register(self, name: str, template: ChatTemplate, override: bool = False):
override(bool): Whether to override the existing template, default to False
"""
assert (
not override and name not in self.templates
override or name not in self.templates
), f"Chat template for the model type {name} has already been registered"
Comment on lines 61 to 63
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using assert for runtime validation is generally discouraged in Python because assertions can be globally disabled (e.g., via the -O flag), which would bypass this safety check. Since this registry logic is important for preventing accidental template overwrites, using an explicit if statement with a ValueError is more robust and follows standard Python practices for argument validation.

        if not override and name in self.templates:
            raise ValueError(f"Chat template for the model type {name} has already been registered")

self.templates[name] = template
Comment on lines 61 to 64
Copy link

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change fixes override=True, but there’s no unit test asserting that register(..., override=True) can overwrite an existing key (and that override=False rejects duplicates). Adding a small test would prevent regressions in this control-flow.

Copilot uses AI. Check for mistakes.

Expand Down
Loading