fix: Make template override arg work correctly

[moehanabi]

Motivation

not override and name not in self.templates make override arg work wrong

Modifications

Related Issues

Accuracy Test

Benchmark & Profiling

Checklist

• Format your code according to the Code Formatting with Pre-Commit.
• Add unit tests as outlined in the Running Unit Tests.
• Update documentation / docstrings / example tutorials as needed, according to Writing Documentation.
• Provide throughput / latency benchmark results and accuracy evaluation results as needed, according to Benchmark and Profiling and Accuracy Results.
• For reviewers: If you haven't made any contributions to this PR and are only assisting with merging the main branch, please remove yourself as a co-author when merging the PR.
• Please feel free to join our Slack channel at https://sgl-fru7574.slack.com/archives/C09784E3EN6 to discuss your PR.

[gemini-code-assist]

Code Review

This pull request corrects a logic error in the register method of the template registry, ensuring that templates can be correctly overridden when the override flag is set. The feedback suggests replacing the assert statement with a more robust if check and raising a ValueError to prevent the validation from being bypassed in optimized Python environments.

[gemini-code-assist]

Using assert for runtime validation is generally discouraged in Python because assertions can be globally disabled (e.g., via the -O flag), which would bypass this safety check. Since this registry logic is important for preventing accidental template overwrites, using an explicit if statement with a ValueError is more robust and follows standard Python practices for argument validation.

        if not override and name in self.templates:
            raise ValueError(f"Chat template for the model type {name} has already been registered")

[Copilot]

Pull request overview

Fixes the TemplateRegistry.register(..., override=True) logic so callers can correctly replace an existing template entry without triggering the duplicate-registration assertion.

Changes:

• Corrected the duplicate-registration assertion to allow overrides when override=True.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

This change fixes override=True, but there’s no unit test asserting that register(..., override=True) can overwrite an existing key (and that override=False rejects duplicates). Adding a small test would prevent regressions in this control-flow.