Skip to content

CPLAT-10038: support modified Enter newline variants#7

Merged
sf-jin-ku merged 1 commit into
sendbird:mainfrom
gavin-jeong:CPLAT-10038-slk-shift-enter-only
May 22, 2026
Merged

CPLAT-10038: support modified Enter newline variants#7
sf-jin-ku merged 1 commit into
sendbird:mainfrom
gavin-jeong:CPLAT-10038-slk-shift-enter-only

Conversation

@gavin-jeong
Copy link
Copy Markdown
Collaborator

JIRA: https://sendbird.atlassian.net/browse/CPLAT-10038

Summary

  • treat observed modified Enter runtime variants as compose newlines
  • keep backslash+Enter as a fallback for environments that collapse Shift+Enter

Test plan

  • go test ./internal/ui -run 'TestHandleInsertMode_ShiftEnterInsertsNewline|TestHandleInsertMode_ShiftReturnInsertsNewline|TestHandleInsertMode_AltEnterInsertsNewline|TestHandleInsertMode_BackslashEnterInsertsNewline|TestHandleInsertMode_ShiftEnterPastVisibleHeight'

Treat observed modified Enter runtime variants as compose newlines and keep a backslash+Enter fallback for environments that collapse Shift+Enter.
Copy link
Copy Markdown

@sf-jin-ku sf-jin-ku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed conflict resolution and/or existing changes for merge.

@sf-jin-ku sf-jin-ku merged commit 212946c into sendbird:main May 22, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants