Skip to content

CPLAT-10038: fix modified Enter and langmap shortcuts#4

Closed
gavin-jeong wants to merge 2 commits into
sendbird:mainfrom
gavin-jeong:CPLAT-10038-slk-enter-langmap
Closed

CPLAT-10038: fix modified Enter and langmap shortcuts#4
gavin-jeong wants to merge 2 commits into
sendbird:mainfrom
gavin-jeong:CPLAT-10038-slk-enter-langmap

Conversation

@gavin-jeong
Copy link
Copy Markdown
Collaborator

JIRA: https://sendbird.atlassian.net/browse/CPLAT-10038

Summary

  • treat the observed modified Enter runtime events as compose newlines in slk
  • merge the langmap worktree's Korean keyboard shortcut normalization so modal shortcuts work under non-English layouts
  • keep backslash+Enter as a newline fallback path

Test plan

  • go test ./internal/ui
  • go test ./...

Show available slash commands when typing / in compose, execute them through Slack's command endpoint, and merge the pending worktree input improvements for tmux keyboard reporting and clipboard paste handling.
Treat the observed alt+enter runtime event as a newline in compose and merge the langmap worktree's Korean keyboard shortcut normalization so modal shortcuts work under non-English layouts.
@gavin-jeong
Copy link
Copy Markdown
Collaborator Author

Superseded by split PRs #7 (modified Enter newline variants) and #8 (Korean IME shortcut normalization).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant